From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Ben Dooks <ben-linux@fluff.org>
Cc: linux-usb@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 06/11] USB: s3c-hsotg: Only load packet per fifo write
Date: Fri, 09 Jul 2010 14:48:15 +0400 [thread overview]
Message-ID: <4C36FE6F.6050606@ru.mvista.com> (raw)
In-Reply-To: <1278460943-16224-7-git-send-email-ben-linux@fluff.org>
Hello.
Ben Dooks wrote:
> Limit the IN FIFO write to a single packet per attempt at writing,
> as per the specifications and ensure that we don't return fifo-full
> so that we can continue writing packets if we have the space.
> Signed-off-by: Ben Dooks <ben-linux@fluff.org>
[...]
> diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c
> index 4196e37..df6a39d 100644
> --- a/drivers/usb/gadget/s3c-hsotg.c
> +++ b/drivers/usb/gadget/s3c-hsotg.c
> @@ -538,6 +538,17 @@ static int s3c_hsotg_write_fifo(struct s3c_hsotg *hsotg,
> if (can_write > 512)
> can_write = 512;
>
> + /* limit the write to one max-packet size worth of data, but allow
> + * the transfer to return that it did not run out of fifo space
> + * doing it. */
According to CodingStyle, the preferred style for the multi-line commnets
is this:
/*
* bla
* bla
*/
WBR, Sergei
next prev parent reply other threads:[~2010-07-09 10:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-07 0:02 s3c-hsotg patches Ben Dooks
2010-07-07 0:02 ` [PATCH 01/11] USB: s3c-hsotg: Increase TX fifo limit Ben Dooks
2010-07-07 0:02 ` [PATCH 02/11] USB: s3c-hsotg: The NPTX/PTX FIFO sizes are in words, not bytes Ben Dooks
2010-07-07 0:02 ` [PATCH 03/11] USB: s3c-hsotg: Avoid overwriting contents of perodic in 'fifo' Ben Dooks
2010-07-07 0:02 ` [PATCH 05/11] USB: s3c-hsotg: Add initial detection and setup for dedicated FIFO mode Ben Dooks
[not found] ` <1278460943-16224-1-git-send-email-ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
2010-07-07 0:02 ` [PATCH 04/11] USB: s3c-hsotg: Re-initialise all FIFOs on USB bus reset Ben Dooks
2010-07-07 0:02 ` [PATCH 06/11] USB: s3c-hsotg: Only load packet per fifo write Ben Dooks
2010-07-09 10:48 ` Sergei Shtylyov [this message]
2010-07-07 0:02 ` [PATCH 08/11] USB: s3c-hsotg: Fix max EP0 IN request length Ben Dooks
2010-07-07 0:02 ` [PATCH 07/11] USB: s3c-hsotg: Check for new request before enqueing new setup Ben Dooks
2010-07-07 0:02 ` [PATCH 09/11] USB: s3c-hsotg: Fix the OUT EP0 limit Ben Dooks
2010-07-07 0:02 ` [PATCH 10/11] USB: s3c-hsotg: Fix OUT packet request retry Ben Dooks
2010-07-07 0:02 ` [PATCH 11/11] USB: s3c-hsotg: Add support for external USB clock Ben Dooks
2010-07-07 15:12 ` s3c-hsotg patches Greg KH
2010-07-14 9:39 ` Marek Szyprowski
[not found] ` <00c401cb2338$84a3f730$8debe590$%szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2010-07-14 15:10 ` Greg KH
[not found] ` <20100714151026.GD24104-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2010-07-15 9:02 ` Ben Dooks
[not found] ` <20100715090222.GD16584-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org>
2010-07-15 10:05 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2010-07-19 8:40 S3C HSOTG fixes Ben Dooks
[not found] ` <1279528850-28245-1-git-send-email-ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
2010-07-19 8:40 ` [PATCH 06/11] USB: s3c-hsotg: Only load packet per fifo write Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C36FE6F.6050606@ru.mvista.com \
--to=sshtylyov@mvista.com \
--cc=ben-linux@fluff.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox