From: Sergei Shtylyov <sshtylyov@mvista.com>
To: MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, kyungmin.park@samsung.com,
kgene.kim@samsung.com, myungjoo.ham@gmail.com,
ben-linux@fluff.org
Subject: Re: [PATCH v5 3/7] ARM: S5P: Added default pll values for APLL 800/1000MHz
Date: Thu, 29 Jul 2010 15:11:20 +0400 [thread overview]
Message-ID: <4C5161D8.1010609@ru.mvista.com> (raw)
In-Reply-To: <1280399145-22761-4-git-send-email-myungjoo.ham@samsung.com>
Hello.
MyungJoo Ham wrote:
> CPUFREQ of S5PV210 uses different APLL settings according to
> different CPU frequencies. We provide such settings values for
> CPUFREQ at pll.h.
> Note that at 1GHz of ARMCLK, APLL should be 1GHz and for other lower
> ARMCLK, APLL should be 800MHz.
> Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
[...]
> diff --git a/arch/arm/plat-s5p/include/plat/pll.h b/arch/arm/plat-s5p/include/plat/pll.h
> index 7db3227..d79042a 100644
> --- a/arch/arm/plat-s5p/include/plat/pll.h
> +++ b/arch/arm/plat-s5p/include/plat/pll.h
> @@ -21,6 +21,9 @@
>
> #include <asm/div64.h>
>
> +#define PLL45XX_APLL_VAL_1000 ((1 << 31) | (125<<16) | (3<<8) | (1))
> +#define PLL45XX_APLL_VAL_800 ((1 << 31) | (100<<16) | (3<<8) | (1))
> +
Incosistent spacing. Why there spaces around the first << but not around
the following? Should be spaces around every <<...
WBR, Sergei
next prev parent reply other threads:[~2010-07-29 11:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-29 10:25 [PATCH v5 0/7] ARM: S5PV210: CPUFREQ Initial Support MyungJoo Ham
2010-07-29 10:25 ` [PATCH v5 1/7] ARM: S5PV210: Allow to probe EVT revision number MyungJoo Ham
2010-07-29 10:25 ` [PATCH v5 2/7] ARM: Samsung SoC: added hclk/pclk info to s3c_freq for s5pv210 cpu-freq MyungJoo Ham
2010-07-29 10:25 ` [PATCH v5 3/7] ARM: S5P: Added default pll values for APLL 800/1000MHz MyungJoo Ham
2010-07-29 10:25 ` [PATCH v5 4/7] ARM: S5P: Virtual Addresses for DMCx registers MyungJoo Ham
2010-07-29 10:25 ` [PATCH v5 5/7] ARM: S5PV210: Access " MyungJoo Ham
2010-07-29 10:25 ` [PATCH v5 6/7] ARM: S5PV210: clock registers (CLK_DIV/SRC/STAT) MyungJoo Ham
2010-07-29 10:25 ` [PATCH v5 7/7] ARM: S5PV210: Initial CPUFREQ Support MyungJoo Ham
2010-07-29 11:11 ` Sergei Shtylyov [this message]
2010-08-02 2:26 ` [PATCH v5 1/7] ARM: S5PV210: Allow to probe EVT revision number Kukjin Kim
2010-08-02 12:37 ` MyungJoo Ham
2010-08-03 0:26 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C5161D8.1010609@ru.mvista.com \
--to=sshtylyov@mvista.com \
--cc=ben-linux@fluff.org \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=myungjoo.ham@gmail.com \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox