From: Tushar Behera <tushar.behera@linaro.org>
To: Jingoo Han <jg1.han@samsung.com>
Cc: Kukjin Kim <kgene.kim@samsung.com>, linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH] ARM: S5PV210: Add USB OTG gadget device support to SMDKV210 board
Date: Fri, 02 Dec 2011 09:11:51 +0530 [thread overview]
Message-ID: <4ED848FF.9070103@linaro.org> (raw)
In-Reply-To: <1322538455-31748-1-git-send-email-jg1.han@samsung.com>
Hi Jingoo,
On Tuesday 29 November 2011 09:17 AM, Jingoo Han wrote:
[ snip ]
> diff --git a/arch/arm/mach-s5pv210/mach-smdkv210.c b/arch/arm/mach-s5pv210/mach-smdkv210.c
[ snip ]
> @@ -308,6 +310,8 @@ static void __init smdkv210_machine_init(void)
>
> samsung_bl_set(&smdkv210_bl_gpio_info,&smdkv210_bl_data);
>
> + clk_xusbxti.rate = 24000000;
> +
Would it be a good idea to set the default rate of clk_xusbxti in
arch/arm/plat-s5p/clock.c and remove the explicit rate setting in all
the machine files?
Currently, the clock is also set in machine files for which ehci is enabled.
> platform_add_devices(smdkv210_devices, ARRAY_SIZE(smdkv210_devices));
> }
>
--
Tushar Behera
prev parent reply other threads:[~2011-12-02 3:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-29 3:47 [PATCH] ARM: S5PV210: Add USB OTG gadget device support to SMDKV210 board Jingoo Han
2011-12-02 3:41 ` Tushar Behera [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED848FF.9070103@linaro.org \
--to=tushar.behera@linaro.org \
--cc=jg1.han@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox