Linux Samsung SOC development
 help / color / mirror / Atom feed
From: Jaehoon Chung <jh80.chung@samsung.com>
To: Thomas Abraham <thomas.abraham@linaro.org>
Cc: Jaehoon Chung <jh80.chung@samsung.com>,
	linux-mmc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
	cjb@laptop.org, grant.likely@secretlab.ca,
	rob.herring@calxeda.com, linux-samsung-soc@vger.kernel.org,
	kgene.kim@samsung.com, girish.shivananjappa@linaro.org,
	tgih.jun@samsung.com, patches@linaro.org
Subject: Re: [PATCH v4 9/9] mmc: dw_mmc: add support for exynos specific implementation of dw-mshc
Date: Tue, 28 Aug 2012 14:16:30 +0900	[thread overview]
Message-ID: <503C542E.9080301@samsung.com> (raw)
In-Reply-To: <CAJuYYwTShXkEJHHUtsSSzQc13b+uYg80iN5H6s4XRRmxk8rRQQ@mail.gmail.com>

On 08/28/2012 02:10 PM, Thomas Abraham wrote:
> On 28 August 2012 10:40, Thomas Abraham <thomas.abraham@linaro.org> wrote:
>> On 28 August 2012 10:25, Jaehoon Chung <jh80.chung@samsung.com> wrote:
>>> Hi Thomas,
>>>
>>> On 08/28/2012 01:48 PM, Thomas Abraham wrote:
>>>> On 27 August 2012 14:28, Jaehoon Chung <jh80.chung@samsung.com> wrote:
>>>>> Hi Thomas,
>>>>>
>>>>>> +     gpio = of_get_named_gpio(slot_np, "wp-gpios", 0);
>>>>>> +     if (gpio_is_valid(gpio)) {
>>>>>> +             if (devm_gpio_request(host->dev, gpio, "dw-mci-wp"))
>>>>>> +                     dev_info(host->dev, "gpio [%d] request failed\n",
>>>>>> +                                             gpio);
>>>>>> +     } else {
>>>>>> +             dev_info(host->dev, "wp gpio not available");
>>>>>> +             host->pdata->quirks |= DW_MCI_QUIRK_NO_WRITE_PROTECT;
>>>>>> +     }
>>>>>> +
>>>>>> +     if (host->pdata->quirks & DW_MCI_QUIRK_BROKEN_CARD_DETECTION)
>>>>>> +             return 0;
>>>>>> +
>>>>>> +     gpio = of_get_named_gpio(slot_np, "samsung,cd-pinmux-gpio", 0);
>>>>>> +     if (gpio_is_valid(gpio)) {
>>>>>> +             if (devm_gpio_request(host->dev, gpio, "dw-mci-cd"))
>>>>> I'm not sure, but i saw mmc_gpio_request_cd() into drivers/mmc/core/slot-gpio.c.
>>>>> Can we use this? i think we can use them.
>>>>> Just my opinion.
>>>>
>>>> Thanks for letting me know about this, I was not aware of this.
>>>> Looking into this code, it is usable for controllers that use a gpio
>>>> (specified using cd-gpios property) as card-detect line. As you know,
>>>> the dw-mmc driver does not support this feature yet. In case of
>>>> exynos, the card-detect pin of the mmc slot is connected to the
>>>> card-detect pad of the dw-mmc controller using pinmux, which is not
>>>> considered as a gpio. Hence, mmc_gpio_request_cd() is not applicable
>>>> in this case.
>>> But In case of external card-detect-pin, we can use the mmc_gpio_request_cd().
>>
>> Yes, we can use. But the current dw-mmc controller driver does not
>> support this feature yet. The existing driver considers that (a)
>> card-detect line is connected to the card-detect pad of the controller
>> or (b) it is broken. For Exynos5250, it is case (a). There is no
> 
> Sorry, I meant smdk5250, not Exynos5250.
Already i tested with my exynos5 board.
If you want, i will share the patch.

Best Regards,
Jaehoon Chung
> 
>> support for using a gpio as an card-detect line.
>>
>> Thanks,
>> Thomas.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

  reply	other threads:[~2012-08-28  5:16 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-26 11:51 [PATCH v4 0/9] mmc: dw_mmc: add support for device tree based instantiation Thomas Abraham
2012-08-26 11:51 ` [PATCH v4 1/9] mmc: dw_mmc: convert copy of struct device in struct dw_mci to a reference Thomas Abraham
2012-08-26 11:52 ` [PATCH v4 2/9] mmc: dw_mmc: Use devm_* functions in dw_mmc platform driver Thomas Abraham
2012-08-26 11:52 ` [PATCH v4 3/9] mmc: dw_mmc: allow probe to succeed even if one slot is initialized Thomas Abraham
2012-08-26 11:52 ` [PATCH v4 4/9] mmc: dw_mmc: lookup for optional biu and ciu clocks Thomas Abraham
2012-08-28 10:43   ` Seungwon Jeon
2012-08-28 11:23     ` Thomas Abraham
2012-08-26 11:52 ` [PATCH v4 5/9] mmc: dw_mmc: add quirk to indicate missing write protect line Thomas Abraham
2012-08-26 11:52 ` [PATCH v4 6/9] mmc: dw_mmc: add device tree support Thomas Abraham
2012-08-26 11:52 ` [PATCH v4 7/9] mmc: dw_mmc: prepare functions in dw_mmc-pltfm for reuse Thomas Abraham
2012-08-26 11:52 ` [PATCH v4 8/9] mmc: dw_mmc: add support for implementation specific callbacks Thomas Abraham
2012-08-26 11:52 ` [PATCH v4 9/9] mmc: dw_mmc: add support for exynos specific implementation of dw-mshc Thomas Abraham
2012-08-27  8:58   ` Jaehoon Chung
2012-08-28  4:48     ` Thomas Abraham
2012-08-28  4:55       ` Jaehoon Chung
2012-08-28  5:10         ` Thomas Abraham
2012-08-28  5:10           ` Thomas Abraham
2012-08-28  5:16             ` Jaehoon Chung [this message]
2012-08-28  5:20               ` Thomas Abraham
2012-08-28  7:06   ` Seungwon Jeon
2012-08-28  7:42     ` Thomas Abraham
2012-08-28 10:43       ` Seungwon Jeon
2012-08-28 11:35         ` Thomas Abraham
2012-08-27  9:31 ` [PATCH v4 0/9] mmc: dw_mmc: add support for device tree based instantiation Will Newton
2012-08-28  4:52   ` Thomas Abraham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=503C542E.9080301@samsung.com \
    --to=jh80.chung@samsung.com \
    --cc=cjb@laptop.org \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=girish.shivananjappa@linaro.org \
    --cc=grant.likely@secretlab.ca \
    --cc=kgene.kim@samsung.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=patches@linaro.org \
    --cc=rob.herring@calxeda.com \
    --cc=tgih.jun@samsung.com \
    --cc=thomas.abraham@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox