Re: [PATCH 7/9] drm/exynos: use of_get_named_gpio to get hdmi hpd gpio

[김승우 <sw0312.kim@samsung.com>]

Hello Rahul,

this patch is not related with others and it looks good to me.

On 2013년 06월 11일 23:11, Rahul Sharma wrote:
> Cleanup by removing flags variable from drm_hdmi_dt_parse_pdata
> which is not used anywhere. Swtiching to of_get_named_gpio instead
> of of_get_named_gpio_flags solved this.
> 
> Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>

Acked-by: Seung-Woo Kim <sw0312.kim@samsung.com>

> ---
>  drivers/gpu/drm/exynos/exynos_hdmi.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c
> index 1eb5ffb..fc6a9b0 100644
> --- a/drivers/gpu/drm/exynos/exynos_hdmi.c
> +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
> @@ -2081,7 +2081,6 @@ static struct s5p_hdmi_platform_data *drm_hdmi_dt_parse_pdata
>  {
>  	struct device_node *np = dev->of_node;
>  	struct s5p_hdmi_platform_data *pd;
> -	enum of_gpio_flags flags;
>  	u32 value;
>  
>  	pd = devm_kzalloc(dev, sizeof(*pd), GFP_KERNEL);
> @@ -2095,7 +2094,7 @@ static struct s5p_hdmi_platform_data *drm_hdmi_dt_parse_pdata
>  		goto err_data;
>  	}
>  
> -	pd->hpd_gpio = of_get_named_gpio_flags(np, "hpd-gpio", 0, &flags);
> +	pd->hpd_gpio = of_get_named_gpio(np, "hpd-gpio", 0);
>  
>  	return pd;
>  
> 

-- 
Seung-Woo Kim
Samsung Software R&D Center
--