From: Stephen Warren <swarren@wwwdotorg.org>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: Pawel Moll <pawel.moll@arm.com>,
Andrzej Hajda <a.hajda@samsung.com>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"laurent.pinchart@ideasonboard.com"
<laurent.pinchart@ideasonboard.com>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Kyungmin Park <kyungmin.park@samsung.com>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
Mark Rutland <Mark.Rutland@arm.com>,
Ian Campbell <ian.campbell@citrix.com>,
"grant.likely@linaro.org" <grant.likely@linaro.org>
Subject: Re: [PATCH RFC v5] s5k5baf: add camera sensor driver
Date: Mon, 19 Aug 2013 16:30:45 -0600 [thread overview]
Message-ID: <52129C95.4070809@wwwdotorg.org> (raw)
In-Reply-To: <5212551F.5020301@samsung.com>
On 08/19/2013 11:25 AM, Sylwester Nawrocki wrote:
> On 08/19/2013 03:25 PM, Pawel Moll wrote:
>> On Mon, 2013-08-19 at 14:18 +0100, Andrzej Hajda wrote:
>>> +++ b/Documentation/devicetree/bindings/media/samsung-s5k5baf.txt
>>> @@ -0,0 +1,51 @@
>>> +Samsung S5K5BAF UXGA 1/5" 2M CMOS Image Sensor with embedded SoC ISP
>>> +-------------------------------------------------------------
>>> +
>>> +Required properties:
>>> +
>>> +- compatible : "samsung,s5k5baf";
>>> +- reg : I2C slave address of the sensor;
>>> +- vdda-supply : analog power supply 2.8V (2.6V to 3.0V);
>>> +- vddreg-supply : regulator input power supply 1.8V (1.7V to 1.9V)
>>> + or 2.8V (2.6V to 3.0);
>>> +- vddio-supply : I/O power supply 1.8V (1.65V to 1.95V)
>>> + or 2.8V (2.5V to 3.1V);
>>> +- gpios : GPIOs connected to STDBYN and RSTN pins,
>>> + in order: STBYN, RSTN;
>>
>> You probably want to use the "[<name>-]gpios" convention here (see
>> Documentation/devicetree/bindings/gpio/gpio.txt), so something like
>> stbyn-gpios and rstn-gpios.
>
> Unless using multiple named properties is really preferred over a single
> "gpios" property I would like to keep the single property containing
> a list of GPIOs. ...
Yes, a separate property for each type of GPIO is typical. Multiple
entries in the same property are allowed if they're used for the same
purpose/type, whereas here they're clearly different things.
Inconsistent with (some) other properties, admittedly...
next prev parent reply other threads:[~2013-08-19 22:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-19 13:18 [PATCH RFC v5] s5k5baf: add camera sensor driver Andrzej Hajda
2013-08-19 13:25 ` Pawel Moll
2013-08-19 17:25 ` Sylwester Nawrocki
2013-08-19 22:30 ` Stephen Warren [this message]
2013-08-19 22:53 ` Tomasz Figa
2013-08-19 22:57 ` Stephen Warren
2013-08-20 15:14 ` Sylwester Nawrocki
2013-08-19 13:39 ` Mark Rutland
2013-08-19 21:03 ` Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52129C95.4070809@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=Mark.Rutland@arm.com \
--cc=a.hajda@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=kyungmin.park@samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox