From: "Łukasz Czerwiński" <l.czerwinski@samsung.com>
To: Mark Brown <broonie@kernel.org>
Cc: s.nawrocki@samsung.com, linux-samsung-soc@vger.kernel.org,
linux-spi@vger.kernel.org
Subject: Re: [RFC PATCH 6/6] spi: spi-s3c64xx: Move DMA initialization
Date: Tue, 10 Sep 2013 15:16:59 +0200 [thread overview]
Message-ID: <522F1BCB.1000400@samsung.com> (raw)
In-Reply-To: <20130910120358.GG29403@sirena.org.uk>
On 09/10/2013 02:03 PM, Mark Brown wrote:
> On Tue, Sep 10, 2013 at 01:24:01PM +0200, Łukasz Czerwiński wrote:
>
>> For 16kB buffer upload time is reduced from ~90ms to ~80ms (I tested
>> with S5C73M3 355560B transfer). If you think that performance
>> increase isn't valuable we should skip that patch.
>
> That does seem worthwhile. Is that just a single transfer in isolation?
>
I gave you summary time when firmware is transferred via 22x16kB blocks.
Each transfer was isolated.
>> amba-pl80 uses virtual DMA channels support so driver won't occupy
>> all the time physical channel. pl330 driver don't use such framework
>> but It will be very hard to occupy all channels at the same time. If
>> I'm wrong please correct me.
>
> OK.
>
Thanks
Lukasz
next prev parent reply other threads:[~2013-09-10 13:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-09 14:09 [RFC PATCH 0/6] spi/s3c64xx: clean up and optimization Lukasz Czerwinski
2013-09-09 14:09 ` [RFC PATCH 1/6] spi: spi-s3c64xx: Remove platform dependent code Lukasz Czerwinski
2013-09-09 14:38 ` Mark Brown
2013-09-11 16:21 ` Heiko Stübner
2013-09-09 14:09 ` [RFC PATCH 2/6] spi: spi-s3c64xx: Correct functions namespacing Lukasz Czerwinski
2013-09-09 14:09 ` [RFC PATCH 3/6] spi: spi-s3c64xx: Add coherent buffers for DMA transfers Lukasz Czerwinski
2013-09-09 14:45 ` Mark Brown
2013-09-10 11:23 ` Łukasz Czerwiński
2013-09-10 12:02 ` Mark Brown
2013-09-11 7:48 ` Łukasz Czerwiński
2013-09-09 14:09 ` [RFC PATCH 4/6] spi: spi-s3c64xx: Remove redundant code Lukasz Czerwinski
2013-09-09 14:09 ` [RFC PATCH 5/6] spi: spi-s3c64xx: Use module_platform_driver() Lukasz Czerwinski
2013-09-09 14:47 ` Mark Brown
2013-09-09 14:09 ` [RFC PATCH 6/6] spi: spi-s3c64xx: Move DMA initialization Lukasz Czerwinski
2013-09-09 14:53 ` Mark Brown
2013-09-10 11:24 ` Łukasz Czerwiński
2013-09-10 12:03 ` Mark Brown
2013-09-10 13:16 ` Łukasz Czerwiński [this message]
2013-09-10 16:32 ` Mark Brown
2013-09-11 7:45 ` Łukasz Czerwiński
2013-09-11 10:03 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=522F1BCB.1000400@samsung.com \
--to=l.czerwinski@samsung.com \
--cc=broonie@kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox