From: Stephen Warren <swarren@wwwdotorg.org>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Arun Kumar K <arun.kk@samsung.com>,
linux-media@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
devicetree@vger.kernel.org, s.nawrocki@samsung.com,
hverkuil@xs4all.nl, mark.rutland@arm.com, Pawel.Moll@arm.com,
galak@codeaurora.org, a.hajda@samsung.com,
sachin.kamat@linaro.org, shaik.ameer@samsung.com,
kilyeon.im@samsung.com, arunkk.samsung@gmail.com
Subject: Re: [PATCH v8 12/12] V4L: Add driver for s5k4e5 image sensor
Date: Fri, 13 Sep 2013 10:14:07 -0600 [thread overview]
Message-ID: <523339CF.9070604@wwwdotorg.org> (raw)
In-Reply-To: <1379076935.4396.13.camel@pizza.hi.pengutronix.de>
On 09/13/2013 06:55 AM, Philipp Zabel wrote:
> Hi Arun,
>
> Am Donnerstag, den 12.09.2013, 17:37 +0530 schrieb Arun Kumar K:
>> This patch adds subdev driver for Samsung S5K4E5 raw image sensor.
>> Like s5k6a3, it is also another fimc-is firmware controlled
>> sensor. This minimal sensor driver doesn't do any I2C communications
>> as its done by ISP firmware. It can be updated if needed to a
>> regular sensor driver by adding the I2C communication.
... [untrimmed patch] ...
>> +Example:
>> +
>> + i2c-isp@13130000 {
>> + s5k4e5@20 {
>> + compatible = "samsung,s5k4e5";
>> + reg = <0x20>;
>> + gpios = <&gpx1 2 1>;
>
> This probably should be 'reset-gpios', too.
... [untrimmed patch] ...
>
> regards
> Philipp
Please delete unnecessary context when replying so that people don't
have to scroll through hundreds of lines of patch to see a 1-line comment.
next prev parent reply other threads:[~2013-09-13 16:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 12:07 [PATCH v8 00/12] Exynos5 IS driver Arun Kumar K
2013-09-12 12:07 ` [PATCH v8 01/12] [media] exynos5-fimc-is: Add Exynos5 FIMC-IS device tree bindings documentation Arun Kumar K
2013-09-12 12:07 ` [PATCH v8 02/12] [media] exynos5-fimc-is: Add driver core files Arun Kumar K
2013-09-16 21:59 ` Sylwester Nawrocki
2013-09-12 12:07 ` [PATCH v8 03/12] [media] exynos5-fimc-is: Add common driver header files Arun Kumar K
2013-09-12 12:07 ` [PATCH v8 04/12] [media] exynos5-fimc-is: Add register definition and context header Arun Kumar K
2013-09-12 12:07 ` [PATCH v8 05/12] [media] exynos5-fimc-is: Add isp subdev Arun Kumar K
2013-09-12 12:07 ` [PATCH v8 06/12] [media] exynos5-fimc-is: Add scaler subdev Arun Kumar K
2013-09-12 12:07 ` [PATCH v8 07/12] [media] exynos5-fimc-is: Add sensor interface Arun Kumar K
2013-09-12 12:07 ` [PATCH v8 08/12] [media] exynos5-fimc-is: Add the hardware pipeline control Arun Kumar K
2013-09-12 12:07 ` [PATCH v8 09/12] [media] exynos5-fimc-is: Add the hardware interface module Arun Kumar K
2013-09-12 12:07 ` [PATCH v8 10/12] [media] exynos5-is: Add Kconfig and Makefile Arun Kumar K
2013-09-12 12:07 ` [PATCH v8 11/12] V4L: s5k6a3: Change sensor min/max resolutions Arun Kumar K
2013-09-12 12:07 ` [PATCH v8 12/12] V4L: Add driver for s5k4e5 image sensor Arun Kumar K
2013-09-13 12:55 ` Philipp Zabel
2013-09-13 16:14 ` Stephen Warren [this message]
[not found] ` <1379076935.4396.13.camel-/rZezPiN1rtR6QfukMTsflXZhhPuCNm+@public.gmane.org>
2013-09-16 5:59 ` Arun Kumar K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=523339CF.9070604@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=Pawel.Moll@arm.com \
--cc=a.hajda@samsung.com \
--cc=arun.kk@samsung.com \
--cc=arunkk.samsung@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=hverkuil@xs4all.nl \
--cc=kilyeon.im@samsung.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=p.zabel@pengutronix.de \
--cc=s.nawrocki@samsung.com \
--cc=sachin.kamat@linaro.org \
--cc=shaik.ameer@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox