Linux Samsung SOC development
 help / color / mirror / Atom feed
From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Seung-Woo Kim <sw0312.kim@samsung.com>,
	linux-media@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	m.chehab@samsung.com
Subject: Re: [PATCH v2] s5p-jpeg: fix uninitialized use in hdr parse
Date: Tue, 15 Oct 2013 09:44:17 +0200	[thread overview]
Message-ID: <525CF251.1040003@samsung.com> (raw)
In-Reply-To: <1381725810-20202-1-git-send-email-sw0312.kim@samsung.com>

Hi Seung-Woo,

On 14/10/13 06:43, Seung-Woo Kim wrote:
> For hdr parse error, it can return false without any assignments
> which cause following build warning.
> 
> drivers/media/platform/s5p-jpeg/jpeg-core.c: In function 's5p_jpeg_parse_hdr':
> drivers/media/platform/s5p-jpeg/jpeg-core.c:432: warning: 'components' may be used uninitialized in this function
> drivers/media/platform/s5p-jpeg/jpeg-core.c:433: warning: 'height' may be used uninitialized in this function
> drivers/media/platform/s5p-jpeg/jpeg-core.c:433: warning: 'width' may be used uninitialized in this function
> 
> Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
> ---
> change from v1
> - add build warning to commit message

Thanks for amending it, the patch added to my tree for v3.13.

--
Regards,
Sylwester

      reply	other threads:[~2013-10-15  7:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-10  7:06 [PATCH] s5p-jpeg: fix uninitialized use in hdr parse Seung-Woo Kim
2013-10-12  9:39 ` Sylwester Nawrocki
2013-10-14  4:27   ` Seung-Woo Kim
2013-10-14  4:43   ` [PATCH v2] " Seung-Woo Kim
2013-10-15  7:44     ` Sylwester Nawrocki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=525CF251.1040003@samsung.com \
    --to=s.nawrocki@samsung.com \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.chehab@samsung.com \
    --cc=sw0312.kim@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox