Re: [PATCH v9 12/13] V4L: s5k6a3: Change sensor min/max resolutions

[Sylwester Nawrocki <s.nawrocki@samsung.com>]

Hi Arun,

My apologies for the delay.

On 27/09/13 12:59, Arun Kumar K wrote:
> s5k6a3 sensor has actual pixel resolution of 1408x1402 against
> the active resolution 1392x1392. The real resolution is needed
> when raw sensor SRGB data is dumped to memory by fimc-lite.
> 
> Signed-off-by: Arun Kumar K <arun.kk@samsung.com>
> Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> ---
>  drivers/media/i2c/s5k6a3.c |   10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/media/i2c/s5k6a3.c b/drivers/media/i2c/s5k6a3.c
> index ccbb4fc..e70e217 100644
> --- a/drivers/media/i2c/s5k6a3.c
> +++ b/drivers/media/i2c/s5k6a3.c
> @@ -25,10 +25,12 @@
>  #include <media/v4l2-async.h>
>  #include <media/v4l2-subdev.h>
>  
> -#define S5K6A3_SENSOR_MAX_WIDTH		1392
> -#define S5K6A3_SENSOR_MAX_HEIGHT	1392
> -#define S5K6A3_SENSOR_MIN_WIDTH		32
> -#define S5K6A3_SENSOR_MIN_HEIGHT	32
> +#define S5K6A3_SENSOR_MAX_WIDTH		1408
> +#define S5K6A3_SENSOR_MAX_HEIGHT	1402

Where these numbers come from ? I digged in the datasheet and the pixel
array size for S5K6A3YX is 1412 x 1412 pixels. I will use this value
in my updated s5k6a3 driver patch I'm going to post today. And I will
drop this patch from this series.

> +#define S5K6A3_SENSOR_ACTIVE_WIDTH	1392
> +#define S5K6A3_SENSOR_ACTIVE_HEIGHT	1392


S5K6A3_SENSOR_ACTIVE_* macros are not used anywhere ? Can they be dropped ?
Same applies to your S5K4E5 driver patch.

> +#define S5K6A3_SENSOR_MIN_WIDTH		(32 + 16)
> +#define S5K6A3_SENSOR_MIN_HEIGHT	(32 + 10)
>  
>  #define S5K6A3_DEF_PIX_WIDTH		1296
>  #define S5K6A3_DEF_PIX_HEIGHT		732
> 

Thanks,
Sylwester