Re: [PATCH 1/2] ARM: dts: Fix status property of mmc nodes for snow board

[Kukjin Kim <kgene.kim@samsung.com>]

On 12/10/13 01:16, Doug Anderson wrote:
> Yuvaraj,
>
> On Sun, Dec 8, 2013 at 10:38 PM, Yuvaraj Kumar C D<yuvaraj.cd@gmail.com>  wrote:
>> Commit 0c3de788 ("ARM: dts: change status property of dwmmc nodes
>> for exynos5250") missed out handling the exynos5250 snow dts file.
>>
>> Signed-off-by : Abhilash Kesavan<a.kesavan@samsung.com>
>>
>> Signed-off-by: Yuvaraj Kumar C D<yuvaraj.cd@samsung.com>
>> ---
>>   arch/arm/boot/dts/cros5250-common.dtsi |    4 ----
>>   arch/arm/boot/dts/exynos5250-snow.dts  |    9 +++++++++
>>   2 files changed, 9 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/cros5250-common.dtsi b/arch/arm/boot/dts/cros5250-common.dtsi
>> index 6470536..1ceb62e 100644
>> --- a/arch/arm/boot/dts/cros5250-common.dtsi
>> +++ b/arch/arm/boot/dts/cros5250-common.dtsi
>> @@ -247,10 +247,6 @@
>>                  };
>>          };
>>
>> -       mmc@12210000 {
>> -               status = "disabled";
>> -       };
>> -
>>          mmc@12220000 {
>>                  num-slots =<1>;
>>                  supports-highspeed;
>> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts
>> index a9395c4..67484d1 100644
>> --- a/arch/arm/boot/dts/exynos5250-snow.dts
>> +++ b/arch/arm/boot/dts/exynos5250-snow.dts
>> @@ -171,11 +171,20 @@
>>                  };
>>          };
>>
>> +       mmc@12200000 {
>> +               status = "okay";
>> +       };
>> +
>> +       mmc@12220000 {
>> +               status = "okay";
>> +       };
>> +
>
> I probably would have put the 12200000 and 12220000 ones in
> cros5250-common since that's where all of the other stuff relating to
> those ports is.  Some of it may need to be moved around once we get
> the HP Chromebook 11 (exynos5250-spring) in place, but until then it
> seems best to keep it all together.
>
> -Doug

OK, sounds better, I don't know well about the HP Chromebook though ;-)

- Kukjin