Re: [PATCH 8/8 v4] crypto:s5p-sss: Use clk_prepare/clk_unprepare

Sylwester Nawrocki
2014-01-23T10:41:27Z

Hi,

On 23/01/14 11:18, Naveen Krishna Ch wrote:
> Hello All,
>
> On 15 January 2014 14:47, Naveen Krishna Chatradhi
> <ch.naveen@samsung.com> wrote:
>> This patch set adds use of clk_prepare/clk_unprepare as
>> required by generic clock framework.
>>
>> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
>> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
>> ---
>> Changes since v3:
>> None
>>
>> drivers/crypto/s5p-sss.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
>> index f7c66c7..870e794 100644
>> --- a/drivers/crypto/s5p-sss.c
>> +++ b/drivers/crypto/s5p-sss.c
>> @@ -648,7 +648,7 @@ static int s5p_aes_probe(struct platform_device *pdev)
>> return -ENOENT;
>> }
>>
>> - clk_enable(pdata->clk);
>> + clk_prepare_enable(pdata->clk);

How about properly checking the return value ?

--
Thanks,
Sylwester