From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH 4/5] ARM: S3C24XX: convert boards to use common restart function Date: Thu, 23 Jan 2014 19:51:34 +0100 Message-ID: <52E164B6.5070206@samsung.com> References: <3105326.uFdOVLyXH8@phil> <2227259.2cNbl9uzOp@phil> <52E15B74.3040409@samsung.com> <7172372.015CdWJg1F@phil> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mailout3.w1.samsung.com ([210.118.77.13]:14123 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751623AbaAWSvv (ORCPT ); Thu, 23 Jan 2014 13:51:51 -0500 Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout3.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MZV00LEGB2DYK60@mailout3.w1.samsung.com> for linux-samsung-soc@vger.kernel.org; Thu, 23 Jan 2014 18:51:49 +0000 (GMT) In-reply-to: <7172372.015CdWJg1F@phil> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: =?ISO-8859-1?Q?Heiko_St=FCbner?= Cc: kgene.kim@samsung.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org On 23.01.2014 19:36, Heiko St=FCbner wrote: > Am Donnerstag, 23. Januar 2014, 19:12:04 schrieb Tomasz Figa: >> Hi Heiko, >> >> On 06.01.2014 19:40, Heiko St=FCbner wrote: >>> This converts all boards to use the new common restart function ins= tead >>> of SoC specific ones. >>> >>> The mach-s3c2416-dt board now tries to setup either a swrst- or wat= chdog- >>> reset so that it will be able to handle more s3c24xx-SoCs later on. >> >> [snip] >> >>> diff --git a/arch/arm/mach-s3c24xx/mach-s3c2416-dt.c >>> b/arch/arm/mach-s3c24xx/mach-s3c2416-dt.c index 0a86953..88716fa4 1= 00644 >>> --- a/arch/arm/mach-s3c24xx/mach-s3c2416-dt.c >>> +++ b/arch/arm/mach-s3c24xx/mach-s3c2416-dt.c >>> @@ -24,6 +24,7 @@ >>> >>> #include >>> #include >>> >>> +#include >>> >>> #include "common.h" >>> >>> @@ -34,6 +35,14 @@ static void __init s3c2416_dt_map_io(void) >>> >>> static void __init s3c2416_dt_machine_init(void) >>> { >>> >>> + s3c24xx_swrst_reset_of_init(); >>> + >>> +#ifdef CONFIG_SAMSUNG_WDT_RESET >>> + /* if no special swrst-device exists try to find a watchdog */ >>> + if (!s3c24xx_swrst_reset_available()) >>> + samsung_wdt_reset_of_init(); >>> +#endif >> >> Hmm... I think it would be safe to assume availability of soft reset= , >> especially if you could move the restart code to the clock driver. > > ok, so something like the following: > > the boards would simply use samsung_watchdog_reset, which should acco= rding to > the manuals be available on all architectures. And the ccf-driver on > appropriate architectures would simple replace the arm_pm_restart cal= lback > with its own SoC specific one? > > For the s3c2412 this also means that the clock-logic would get simpli= fied. > > > Like this, or do I overlook something? Hmm, this would mean a dependency on CONFIG_SAMSUNG_WDT_RESET then. Is=20 there a need to fall back to it on platforms which support soft reset=20 (assuming that CCF driver would always install its restart handler on=20 applicable platforms)? Note that you can make the restart field NULL in mach_desc in board fil= es. Best regards, Tomasz