From: Tomasz Figa <tomasz.figa@gmail.com>
To: taikyung yu <taikyung.yu@gmail.com>,
t.figa@samsung.com, linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH] clk: samsung: pll: bugfix about segmentation fault
Date: Sun, 09 Feb 2014 17:26:35 +0100 [thread overview]
Message-ID: <52F7AC3B.10503@gmail.com> (raw)
In-Reply-To: <1391950279-10252-1-git-send-email-taikyung.yu@gmail.com>
Hi,
On 09.02.2014 13:51, taikyung yu wrote:
> init has pll initialization information. but it is local variable.
> so it is just valid in samsung_clk_register_pll2550x() function.
>
> Signed-off-by: taikyung yu <taikyung.yu@gmail.com>
> ---
> drivers/clk/samsung/clk-pll.c | 61 +++++++++++++++++++++++++----------------
> 1 file changed, 37 insertions(+), 24 deletions(-)
As far as I can see all the data from clk_init_data struct are copied by
clk_register(), so I'm not sure if there is any reason why current code
could be wrong.
Have you actually observed any issues without this patch?
Best regards,
Tomasz
prev parent reply other threads:[~2014-02-09 16:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-09 12:51 [PATCH] clk: samsung: pll: bugfix about segmentation fault taikyung yu
2014-02-09 16:26 ` Tomasz Figa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F7AC3B.10503@gmail.com \
--to=tomasz.figa@gmail.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=t.figa@samsung.com \
--cc=taikyung.yu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox