From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sudeep Holla Subject: Re: [PATCH v2 2/2] Documentation: devicetree: Add boost-frequency binding to list boost mode frequency Date: Mon, 10 Feb 2014 10:51:51 +0000 Message-ID: <52F8AF47.3080508@arm.com> References: <1391786342-11812-1-git-send-email-thomas.ab@samsung.com> <1391786342-11812-3-git-send-email-thomas.ab@samsung.com> <52F50698.4060305@arm.com> <52F509BD.70903@arm.com> <52F51888.5010608@arm.com> <52F51FCD.5000009@arm.com> <20140210083836.44b519bf@amdc2363> Mime-Version: 1.0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: 8BIT Return-path: Received: from service87.mimecast.com ([91.220.42.44]:60961 "EHLO service87.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752357AbaBJKvh convert rfc822-to-8bit (ORCPT ); Mon, 10 Feb 2014 05:51:37 -0500 In-Reply-To: <20140210083836.44b519bf@amdc2363> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Lukasz Majewski , Thomas Abraham Cc: Sudeep.Holla@arm.com, Nishanth Menon , "linux-pm@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "rjw@rjwysocki.net" , "linux-samsung-soc@vger.kernel.org" , "kgene.kim@samsung.com" , "t.figa@samsung.com" , "viresh.kumar@linaro.org" , "thomas.ab@samsung.com" , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala On 10/02/14 07:38, Lukasz Majewski wrote: > Hi Thomas, Sudeep, > >> On Fri, Feb 7, 2014 at 11:32 PM, Sudeep Holla >> wrote: >>> On 07/02/14 17:37, Nishanth Menon wrote: >>>> On Fri, Feb 7, 2014 at 11:31 AM, Sudeep Holla >>>> wrote: >>> >>> [...] >>> >>>>> Yes I think its counter-intuitive as it's visible to the >>>>> userspace(list of frequencies and the boost parameters are >>>>> exposed through sysfs) >>>> >>>> That will be a different problem -> as currently every single >>>> frequency in the cpufreq list has ability to be marked as boost >>>> frequency - if userspace does not maintain that, then, IMHO, fix >>>> the userspace :D >>>> >>> >>> /sys/devices/system/cpu/cpu*/cpufreq/scaling_available_frequencies >>> gives the list of frequencies based on the state of the boost >>> feature at anytime. >> >> The list of frequencies in >> /sys/devices/system/cpu/cpu*/cpufreq/scaling_available_frequencies >> does not change based in the state of the boost feature (enabled or >> disabled). But the scaling_max_frequency and scaling_min_frequency are >> updated based on the set of available + boost frequencies available. > > With boost intended behavior is as follow: > > /sys/devices/system/cpu/cpu*/cpufreq/scaling_available_frequencies [1] > > shows the non boost frequencies no matter if boost is enabled or not. > Those are the "normal" frequencies. > > When boost is supported (by enabling the CONFIG_CPU_FREQ_BOOST_SW) > extra sysfs attribute shows up: > > /sys/devices/system/cpu/cpu0/cpufreq/scaling_boost_frequencies [2] > in which are listed only the boost frequencies. > Correct, sorry I misunderstood this to dynamic change in scaling_available_frequencies based on state of boot. Regards, Sudeep