From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH v1 0/2] exynos_mct driver: fix irq allocation and cleanup Date: Thu, 13 Feb 2014 13:36:18 +0100 Message-ID: <52FCBC42.6020904@samsung.com> References: <1392260923-31659-1-git-send-email-t.dakhran@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mailout1.w1.samsung.com ([210.118.77.11]:13625 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753189AbaBMMgY (ORCPT ); Thu, 13 Feb 2014 07:36:24 -0500 In-reply-to: <1392260923-31659-1-git-send-email-t.dakhran@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Tarek Dakhran , linux-kernel@vger.kernel.org Cc: Russell King , Kukjin Kim , Daniel Lezcano , Sachin Kamat , Thomas Gleixner , Tarek Dakhran , Vyacheslav Tyrtov , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Hi Tarek, On 13.02.2014 04:08, Tarek Dakhran wrote: > exynos4_local_timer_setup called on the secondary cpu before > irqs are enabled. request_irq can sleep, which produces next warning: > > on boot: > [ 0.370000] CPU0: thread -1, cpu 0, socket 0, mpidr 80000000 > [ 0.370000] Setting up static identity map for 0x403b5700 - 0x403b5758 > [ 0.395000] CPU1: Booted secondary processor > [ 0.395000] ------------[ cut here ]------------ > [ 0.395000] WARNING: CPU: 1 PID: 0 at kernel/locking/lockdep.c:2742 lockdep_trace_alloc+0xe0/0xfc() > [ 0.395000] DEBUG_LOCKS_WARN_ON(irqs_disabled_flags(flags)) > [ 0.395000] Modules linked in: > [ 0.395000] CPU: 1 PID: 0 Comm: swapper/1 Not tainted 3.14.0-rc2-00004-g0db95f4 #128 > [ 0.395000] [] (unwind_backtrace) from [] (show_stack+0x10/0x14) > [ 0.395000] [] (show_stack) from [] (dump_stack+0x6c/0xb8) > [ 0.395000] [] (dump_stack) from [] (warn_slowpath_common+0x68/0x8c) > [ 0.395000] [] (warn_slowpath_common) from [] (warn_slowpath_fmt+0x30/0x40) > [ 0.395000] [] (warn_slowpath_fmt) from [] (lockdep_trace_alloc+0xe0/0xfc) > [ 0.395000] [] (lockdep_trace_alloc) from [] (kmem_cache_alloc+0x24/0x160) > [ 0.395000] [] (kmem_cache_alloc) from [] (request_threaded_irq+0x64/0x130) > [ 0.395000] [] (request_threaded_irq) from [] (exynos4_local_timer_setup+0xd0/0x124) > [ 0.395000] [] (exynos4_local_timer_setup) from [] (exynos4_mct_cpu_notify+0x78/0xf0) > [ 0.395000] [] (exynos4_mct_cpu_notify) from [] (notifier_call_chain+0x44/0x84) > [ 0.395000] [] (notifier_call_chain) from [] (__cpu_notify+0x24/0x40) > [ 0.395000] [] (__cpu_notify) from [] (secondary_start_kernel+0xe4/0x134) > [ 0.395000] [] (secondary_start_kernel) from [<40008624>] (0x40008624) > [ 0.395000] ---[ end trace 347890460e745f50 ]--- > [ 0.420000] CPU1: update cpu_power 1024 > [ 0.420000] CPU1: thread -1, cpu 1, socket 0, mpidr 80000001 > > on hotplug: > [ 108.040000] CPU3: Booted secondary processor > [ 108.040000] BUG: sleeping function called from invalid context at mm/slub.c:965 > [ 108.040000] in_atomic(): 1, irqs_disabled(): 128, pid: 0, name: swapper/3 > [ 108.040000] INFO: lockdep is turned off. > [ 108.040000] irq event stamp: 0 > [ 108.040000] hardirqs last enabled at (0): [< (null)>] (null) > [ 108.040000] hardirqs last disabled at (0): [] copy_process.part.2+0x2a4/0x12f4 > [ 108.040000] softirqs last enabled at (0): [] copy_process.part.2+0x2a4/0x12f4 > [ 108.040000] softirqs last disabled at (0): [< (null)>] (null) > [ 108.040000] CPU: 3 PID: 0 Comm: swapper/3 Tainted: G W 3.14.0-rc2-00004-g0db95f4 #128 > [ 108.040000] [] (unwind_backtrace) from [] (show_stack+0x10/0x14) > [ 108.040000] [] (show_stack) from [] (dump_stack+0x6c/0xb8) > [ 108.040000] [] (dump_stack) from [] (kmem_cache_alloc+0xd4/0x160) > [ 108.040000] [] (kmem_cache_alloc) from [] (request_threaded_irq+0x64/0x130) > [ 108.040000] [] (request_threaded_irq) from [] (exynos4_local_timer_setup+0xd0/0x124) > [ 108.040000] [] (exynos4_local_timer_setup) from [] (exynos4_mct_cpu_notify+0x78/0xf0) > [ 108.040000] [] (exynos4_mct_cpu_notify) from [] (notifier_call_chain+0x44/0x84) > [ 108.040000] [] (notifier_call_chain) from [] (__cpu_notify+0x24/0x40) > [ 108.040000] [] (__cpu_notify) from [] (secondary_start_kernel+0xe4/0x134) > [ 108.040000] [] (secondary_start_kernel) from [<40008624>] (0x40008624) > > First patch fixes this problem by removing request_irq from exynos4_local_timer_setup > Second removes non-dt stuff. > > Tested on linux kernel v3.14-rc2. It would be nice to say on which boards it has been tested. Let me check this on our boards anyway. Best regards, Tomasz