From: Andrzej Hajda <a.hajda@samsung.com>
To: Inki Dae <inki.dae@samsung.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
DRI mailing list <dri-devel@lists.freedesktop.org>,
Denis Carikli <denis@eukrea.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Rob Herring <robh+dt@kernel.org>,
Kumar Gala <galak@codeaurora.org>,
Grant Likely <grant.likely@linaro.org>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH 8/9] drm/exynos/fimd: use polarization flags provided by drm_display_mode
Date: Thu, 20 Mar 2014 08:01:41 +0100 [thread overview]
Message-ID: <532A9255.2030403@samsung.com> (raw)
In-Reply-To: <CAAQKjZOh-qFEn3ex7YwCRDwOjpV=s-8JGj68Yx7qOpS+oy2-ww@mail.gmail.com>
On 03/20/2014 07:03 AM, Inki Dae wrote:
> Thanks for your contributions,
>
>
> 2014-03-17 19:27 GMT+09:00 Andrzej Hajda <a.hajda@samsung.com>:
>> The patch replaces fimd private bindings for signal polarization by
>> polarization flags provided by drm_display_mode.
>>
>
> This patch needs below patch not merged yet,
> drm: drm_display_mode: add signal polarity flags
>
> So let me pick up all of your path series except for patch 7 and 8.
> And for these two patches, later.
>
> Your opinion?
Yes, please do it.
Regards
Andrzej
>
> Thanks,
> Inki Dae
>
>> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
>> ---
>> drivers/gpu/drm/exynos/exynos_drm_fimd.c | 12 +++++-------
>> 1 file changed, 5 insertions(+), 7 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
>> index 15d6b37..dbfad4e 100644
>> --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
>> +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
>> @@ -115,7 +115,6 @@ struct fimd_context {
>> unsigned int default_win;
>> unsigned long irq_flags;
>> u32 vidcon0;
>> - u32 vidcon1;
>> bool suspended;
>> int pipe;
>> wait_queue_head_t wait_vsync_queue;
>> @@ -232,7 +231,11 @@ static void fimd_commit(struct exynos_drm_manager *mgr)
>> return;
>>
>> /* setup polarity values */
>> - vidcon1 = ctx->vidcon1;
>> + vidcon1 = 0;
>> + if (mode->pol_flags & DRM_MODE_FLAG_POL_DE_NEGEDGE)
>> + vidcon1 |= VIDCON1_INV_VDEN;
>> + if (mode->pol_flags & DRM_MODE_FLAG_POL_PIXDATA_NEGEDGE)
>> + vidcon1 |= VIDCON1_INV_VCLK;
>> if (mode->flags & DRM_MODE_FLAG_NVSYNC)
>> vidcon1 |= VIDCON1_INV_VSYNC;
>> if (mode->flags & DRM_MODE_FLAG_NHSYNC)
>> @@ -875,11 +878,6 @@ static int fimd_probe(struct platform_device *pdev)
>> ctx->dev = dev;
>> ctx->suspended = true;
>>
>> - if (of_property_read_bool(dev->of_node, "samsung,invert-vden"))
>> - ctx->vidcon1 |= VIDCON1_INV_VDEN;
>> - if (of_property_read_bool(dev->of_node, "samsung,invert-vclk"))
>> - ctx->vidcon1 |= VIDCON1_INV_VCLK;
>> -
>> ctx->bus_clk = devm_clk_get(dev, "fimd");
>> if (IS_ERR(ctx->bus_clk)) {
>> dev_err(dev, "failed to get bus clock\n");
>> --
>> 1.8.3.2
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2014-03-20 7:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 10:27 [PATCH 0/9] Restore parallel display support for Exynos based boards Andrzej Hajda
2014-03-17 10:27 ` [PATCH 1/9] drm/exynos: delay fbdev initialization until an output is connected Andrzej Hajda
2014-03-17 10:27 ` [PATCH 2/9] drm/exynos: init kms poll after creation of connectors Andrzej Hajda
2014-03-17 10:27 ` [PATCH 3/9] drm/exynos: correct timing porch conversion Andrzej Hajda
2014-03-17 10:27 ` [PATCH 4/9] exynos/fimd: add parallel output related bindings Andrzej Hajda
2014-03-17 10:27 ` [PATCH 5/9] drm/exynos: restore parallel output interface support Andrzej Hajda
2014-03-17 12:03 ` [PATCH v2 " Andrzej Hajda
2014-03-17 10:27 ` [PATCH 6/9] ARM: dts: exynos4210-universal: add exynos/fimd node Andrzej Hajda
2014-03-17 10:27 ` [PATCH 7/9] drm/modes: add polarization handling to mode conversion Andrzej Hajda
2014-03-17 10:27 ` [PATCH 8/9] drm/exynos/fimd: use polarization flags provided by drm_display_mode Andrzej Hajda
2014-03-20 6:03 ` Inki Dae
2014-03-20 7:01 ` Andrzej Hajda [this message]
2014-03-20 13:26 ` [PATCH] ARM: dts: exynos4210-universal: add fimd polarization settings Andrzej Hajda
2014-03-21 5:36 ` Inki Dae
[not found] ` <1395052045-23848-1-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-03-17 10:27 ` [PATCH 9/9] drm/exynos/fimd: remove unused variable Andrzej Hajda
2014-03-17 13:16 ` [PATCH v2 " Andrzej Hajda
2014-03-18 13:05 ` [PATCH 0/9] Restore parallel display support for Exynos based boards Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532A9255.2030403@samsung.com \
--to=a.hajda@samsung.com \
--cc=denis@eukrea.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=inki.dae@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox