From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pankaj Dubey Subject: Re: [PATCH 01/10] ARM: EXYNOS: Cleanup "mach-exynos/common.h" file Date: Thu, 10 Apr 2014 13:35:55 +0900 Message-ID: <53461FAB.6060303@samsung.com> References: <1396425058-4012-1-git-send-email-pankaj.dubey@samsung.com> <1396425058-4012-2-git-send-email-pankaj.dubey@samsung.com> <53441CF5.80003@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <53441CF5.80003@samsung.com> Sender: linux-kernel-owner@vger.kernel.org To: Tomasz Figa Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com, linux@arm.linux.org.uk, chow.kim@samsung.com List-Id: linux-samsung-soc@vger.kernel.org Hi Tomasz, On 04/09/2014 12:59 AM, Tomasz Figa wrote: > Hi Pankaj, > > On 02.04.2014 09:50, Pankaj Dubey wrote: >> Remove unused declarations from "mach-exynos/common.h" >> >> Signed-off-by: Pankaj Dubey >> --- >> arch/arm/mach-exynos/common.h | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/arch/arm/mach-exynos/common.h b/arch/arm/mach-exynos/common.h >> index 9ef3f83..277a83e 100644 >> --- a/arch/arm/mach-exynos/common.h >> +++ b/arch/arm/mach-exynos/common.h >> @@ -15,9 +15,6 @@ >> #include >> #include >> >> -void mct_init(void __iomem *base, int irq_g0, int irq_l0, int irq_l1); >> - >> -struct map_desc; >> void exynos_init_io(void); >> void exynos_restart(enum reboot_mode mode, const char *cmd); >> void exynos_cpuidle_init(void); >> > > You could also drop a bit more. From the context above I can see that at least > exynos_restart() and exynos_init_io() are never used outside of files they are > defined in, so they too could be dropped from this header. Looking at rest of > the header, there seems to be a lot of similar definitions. If cleaning up the > header anyway, could you take care of them as well? > Thanks for review. Sure, I will take care of other functions which are not required in this header file in next version. > Best regards, > Tomasz > -- Best Regards, Pankaj Dubey