From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pankaj Dubey Subject: Re: [PATCH 03/10] ARM: EXYNOS: Move SYSREG definition into sys-reg specific file Date: Fri, 11 Apr 2014 15:07:14 +0900 Message-ID: <53478692.3020406@samsung.com> References: <1396425058-4012-1-git-send-email-pankaj.dubey@samsung.com> <1396425058-4012-4-git-send-email-pankaj.dubey@samsung.com> <533BF433.6000209@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <533BF433.6000209@samsung.com> Sender: linux-kernel-owner@vger.kernel.org To: Sylwester Nawrocki Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com, linux@arm.linux.org.uk, chow.kim@samsung.com, Young-Gun Jang List-Id: linux-samsung-soc@vger.kernel.org On 04/02/2014 08:27 PM, Sylwester Nawrocki wrote: > Hi, > > On 02/04/14 09:50, Pankaj Dubey wrote: >> From: Young-Gun Jang >> >> While making PMU (Power Mengement Unit) implementation device tree based, >> there are few offsets related with SYSREG present in regs-pmu.h, so let's >> make a new header file "regs-sys.h" to keep all such SYSREG related >> register definition and remove them from "regs-pmu.h" >> >> Signed-off-by: Young-Gun Jang >> Signed-off-by: Pankaj Dubey >> --- >> arch/arm/mach-exynos/exynos.c | 1 + >> arch/arm/mach-exynos/pm.c | 1 + >> arch/arm/mach-exynos/regs-pmu.h | 3 --- >> arch/arm/mach-exynos/regs-sys.h | 22 ++++++++++++++++++++++ >> 4 files changed, 24 insertions(+), 3 deletions(-) >> create mode 100644 arch/arm/mach-exynos/regs-sys.h > [...] >> diff --git a/arch/arm/mach-exynos/regs-sys.h b/arch/arm/mach-exynos/regs-sys.h >> new file mode 100644 >> index 0000000..84332b0 >> --- /dev/null >> +++ b/arch/arm/mach-exynos/regs-sys.h >> @@ -0,0 +1,22 @@ >> +/* >> + * Copyright (c) 2014 Samsung Electronics Co., Ltd. >> + * http://www.samsung.com >> + * >> + * EXYNOS - system register definition >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published by the Free Software Foundation. >> +*/ >> + >> +#ifndef __ASM_ARCH_REGS_SYS_H >> +#define __ASM_ARCH_REGS_SYS_H __FILE__ >> + >> +#include >> + >> +#define S5P_SYSREG(x) (S3C_VA_SYS + (x)) >> + >> +/* For EXYNOS5 */ >> +#define EXYNOS5_SYS_I2C_CFG S5P_SYSREG(0x0234) > Can this be defined as a regular register offset in a header file > placed at include/linux/mfd/syscon/ ? I.e. can the mfd syscon driver be > used instead of these hacks ? > No. As currently SysRegs are being accessed via iodesc table and not via DT, it has dependency on "mach/map.h". We separated these definitions from "regs-pmu.h" as it does not belong to EXYNOS PMU IP. But this can be done once we make some way of accessing SysReg register sets via DT. -- Best Regards, Pankaj Dubey