From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pankaj Dubey Subject: Re: [PATCH 1/2] phy: samsung: add simple phys for exynos5250 SoC Date: Mon, 21 Apr 2014 09:50:47 +0900 Message-ID: <53546B67.3000308@samsung.com> References: <1397988495-29376-1-git-send-email-rahul.sharma@samsung.com> <1397988495-29376-2-git-send-email-rahul.sharma@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mailout3.samsung.com ([203.254.224.33]:12487 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751043AbaDUAdM (ORCPT ); Sun, 20 Apr 2014 20:33:12 -0400 Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N4C00LUTUVAVZ70@mailout3.samsung.com> for linux-samsung-soc@vger.kernel.org; Mon, 21 Apr 2014 09:33:10 +0900 (KST) In-reply-to: <1397988495-29376-2-git-send-email-rahul.sharma@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Rahul Sharma Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, kishon@ti.com, kgene.kim@samsung.com, inki.dae@samsung.com, t.stanislaws@samsung.com, joshi@samsung.com, r.sh.open@gmail.com Hi Rahul, On 04/20/2014 07:08 PM, Rahul Sharma wrote: > From: Rahul Sharma > > Extend the support for simple phys for exynos5250 SoC > in simple phy driver. > > Change-Id: I39e7745e01ae4b1cf5063dce8a29ebdc37180130 Change-Id should be removed. Missing Signed-off-by. > --- > .../devicetree/bindings/phy/samsung-phy.txt | 22 ++++++++++++++++++++ > drivers/phy/exynos-simple-phy.c | 9 ++++++++ > 2 files changed, 31 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/samsung-phy.txt b/Documentation/devicetree/bindings/phy/samsung-phy.txt > index f97c4c3..f469099 100644 > --- a/Documentation/devicetree/bindings/phy/samsung-phy.txt > +++ b/Documentation/devicetree/bindings/phy/samsung-phy.txt > @@ -122,6 +122,7 @@ Required properties: > - compatible : should be one of the listed compatibles: > - "samsung,exynos4210-simple-phy" > - "samsung,exynos4412-simple-phy" > + - "samsung,exynos5250-simple-phy" > - reg : offset and length of the register set; > - #phy-cells : from the generic phy bindings, must be 1; > > @@ -138,3 +139,24 @@ the PHY specifier identifies the PHY and its meaning is as follows: > 0 - HDMI PHY, > 1 - ADC PHY, > > +For "samsung,exynos5250-simple-phy" compatible PHYs the second cell in > +the PHY specifier identifies the PHY and its meaning is as follows: > + 0 - HDMI PHY, > + 1 - ADC PHY, > + 2 - ADC PHY, > + > +Example: > +Simple PHY provider node: > + > + simplephys: simple-phys@10040000 { > + compatible = "samsung,exynos5250-simple-phy"; > + reg = <0x10040000 0x10000>; > + #phy-cells = <1>; > + }; > + > +Other nodes accessing simple PHYs: > + > + hdmi { > + phys = <&simplephys 0>; > + phy-names = "hdmiphy"; > + }; > diff --git a/drivers/phy/exynos-simple-phy.c b/drivers/phy/exynos-simple-phy.c > index 57ad338..187f6b1 100644 > --- a/drivers/phy/exynos-simple-phy.c > +++ b/drivers/phy/exynos-simple-phy.c > @@ -64,11 +64,20 @@ static const u32 exynos4412_offsets[] = { > ~0, /* end mark */ > }; > > +static const u32 exynos5250_offsets[] = { > + 0x0700, /* HDMI_PHY */ > + 0x0718, /* ADC_PHY */ > + 0x0724, /* SATA_PHY */ > + ~0, /* end mark */ > +}; > + > static const struct of_device_id exynos_phy_of_match[] = { > { .compatible = "samsung,exynos4210-simple-phy", > .data = exynos4210_offsets}, > { .compatible = "samsung,exynos4412-simple-phy", > .data = exynos4412_offsets}, > + { .compatible = "samsung,exynos5250-simple-phy", > + .data = exynos5250_offsets}, > { }, > }; > MODULE_DEVICE_TABLE(of, exynos_phy_of_match); -- Best Regards, Pankaj Dubey