From: Arun Kumar K <arunkk.samsung@gmail.com>
To: Sachin Kamat <sachin.kamat@linaro.org>,
Arun Kumar K <arun.kk@samsung.com>
Cc: linux-media <linux-media@vger.kernel.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
Kamil Debski <k.debski@samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Pawel Osciak <posciak@chromium.org>,
Kiran Avnd <avnd.kiran@samsung.com>
Subject: Re: [PATCH 2/3] [media] s5p-mfc: Core support to add v8 decoder
Date: Wed, 30 Apr 2014 11:15:15 +0530 [thread overview]
Message-ID: <53608DEB.1020608@gmail.com> (raw)
In-Reply-To: <CAK9yfHzB11kJbOcL-jHHo_P4D2nXtHuGRM_FT0mNuvV0SLywrQ@mail.gmail.com>
Hi Sachin,
Thank you for the review.
On 04/29/14 22:45, Sachin Kamat wrote:
> Hi Arun,
>
> On 23 April 2014 18:27, Arun Kumar K <arun.kk@samsung.com> wrote:
>> From: Kiran AVND <avnd.kiran@samsung.com>
>>
>> This patch adds variant data and core support for
>> V8 decoder. This patch also adds the register definition
>> file for new firmware version v8 for MFC.
>>
>> Signed-off-by: Kiran AVND <avnd.kiran@samsung.com>
>> Signed-off-by: Pawel Osciak <posciak@chromium.org>
>> Signed-off-by: Arun Kumar K <arun.kk@samsung.com>
>> ---
> <...>
>> +
>> +/* Returned value register for specific setting */
>> +#define S5P_FIMV_D_RET_PICTURE_TAG_TOP_V8 0xf674
>> +#define S5P_FIMV_D_RET_PICTURE_TAG_BOT_V8 0xf678
>> +#define S5P_FIMV_D_MVC_VIEW_ID_V8 0xf6d8
>> +
>> +/* SEI related information */
>> +#define S5P_FIMV_D_FRAME_PACK_SEI_AVAIL_V8 0xf6dc
>> +
>> +/* MFCv8 Context buffer sizes */
>> +#define MFC_CTX_BUF_SIZE_V8 (30 * SZ_1K) /* 30KB */
>
> Please include header file for size macros.
>
The file linux/sizes.h is included in regs-mfc-v6.h which
inturn gets included in this file. Isnt that fine?
> <...>
>> };
>> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_common.h b/drivers/media/platform/s5p-mfc/s5p_mfc_common.h
>> index 48a14b5..f0e63f5 100644
>> --- a/drivers/media/platform/s5p-mfc/s5p_mfc_common.h
>> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_common.h
>> @@ -23,8 +23,7 @@
>> #include <media/v4l2-ioctl.h>
>> #include <media/videobuf2-core.h>
>> #include "regs-mfc.h"
>> -#include "regs-mfc-v6.h"
>> -#include "regs-mfc-v7.h"
>> +#include "regs-mfc-v8.h"
>>
>> /* Definitions related to MFC memory */
>>
>> @@ -705,5 +704,6 @@ void set_work_bit_irqsave(struct s5p_mfc_ctx *ctx);
>> #define IS_TWOPORT(dev) (dev->variant->port_num == 2 ? 1 : 0)
>> #define IS_MFCV6_PLUS(dev) (dev->variant->version >= 0x60 ? 1 : 0)
>> #define IS_MFCV7(dev) (dev->variant->version >= 0x70 ? 1 : 0)
>
> Is MFC v8 superset of MFC v7?
>
Yes it is a superset.
So the last patch in this series renames IS_MFCV7 to IS_MFCV7_PLUS.
Regards
Arun
>> +#define IS_MFCV8(dev) (dev->variant->version >= 0x80 ? 1 : 0)
>
next prev parent reply other threads:[~2014-04-30 5:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-23 12:57 [PATCH 0/3] Add MFCv8 support Arun Kumar K
2014-04-23 12:57 ` [PATCH 1/3] [media] s5p-mfc: Add variants to access mfc registers Arun Kumar K
2014-05-08 16:31 ` Kamil Debski
2014-05-09 1:00 ` Pawel Osciak
2014-05-09 4:49 ` Arun Kumar K
2014-05-09 5:20 ` Tomasz Figa
2014-05-09 5:31 ` Arun Kumar K
2014-05-13 10:33 ` Kamil Debski
2014-05-13 10:32 ` Kamil Debski
2014-05-13 11:24 ` Arun Kumar K
2014-04-23 12:57 ` [PATCH 2/3] [media] s5p-mfc: Core support to add v8 decoder Arun Kumar K
2014-04-29 17:15 ` Sachin Kamat
2014-04-30 5:45 ` Arun Kumar K [this message]
2014-04-30 5:49 ` Sachin Kamat
2014-04-30 5:52 ` Arun Kumar K
2014-04-23 12:57 ` [PATCH 3/3] [media] s5p-mfc: Rename IS_MFCV7 macro Arun Kumar K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53608DEB.1020608@gmail.com \
--to=arunkk.samsung@gmail.com \
--cc=arun.kk@samsung.com \
--cc=avnd.kiran@samsung.com \
--cc=k.debski@samsung.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=posciak@chromium.org \
--cc=s.nawrocki@samsung.com \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox