From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCHv4 7/7] ARM: dts: Add device tree sources for Exynos3250 Date: Fri, 09 May 2014 10:01:12 +0200 Message-ID: <536C8B48.90706@samsung.com> References: <1398388572-30239-1-git-send-email-cw00.choi@samsung.com> <1398388572-30239-8-git-send-email-cw00.choi@samsung.com> <535B0324.50705@gmail.com> <535B9A98.3060206@gmail.com> <536C7A96.3000906@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout2.w1.samsung.com ([210.118.77.12]:49158 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751370AbaEIIBU (ORCPT ); Fri, 9 May 2014 04:01:20 -0400 In-reply-to: <536C7A96.3000906@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Chanwoo Choi , Tomasz Figa Cc: kgene.kim@samsung.com, linux-kernel@vger.kernel.org, linux@arm.linux.org.uk, ben-linux@fluff.org, arnd@arndb.de, olof@lixom.net, marc.zyngier@arm.com, thomas.abraham@linaro.org, kyungmin.park@samsung.com, inki.dae@samsung.com, sw0312.kim@samsung.com, hyunhee.kim@samsung.com, yj44.cho@samsung.com, chanho61.park@samsung.com, sajjan.linux@gmail.com, tushar.behera@linaro.org, sachin.kamat@linaro.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Jaehoon Chung , Bartlomiej Zolnierkiewicz , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala On 09.05.2014 08:49, Chanwoo Choi wrote: > Hi Tomasz, > > On 04/26/2014 08:38 PM, Tomasz Figa wrote: >> On 26.04.2014 02:51, Tomasz Figa wrote: >>> Hi Chanwoo, >>> >>> On 25.04.2014 03:16, Chanwoo Choi wrote: >>>> From: Tomasz Figa >>>> >>>> This patch add new exynos3250.dtsi to support Exynos3250 SoC based on >>>> Cortex-A7 >>>> dual core and includes following dt nodes: >>>> >>>> - GIC interrupt controller >>>> - Pinctrl to control GPIOs >>>> - Clock controller >>>> - CPU information (Cortex-A7 dual core) >>>> - UART to support serial port >>>> - MCT (Multi Core Timer) >>>> - ADC (Analog Digital Converter) >>>> - I2C/SPI bus >>>> - Power domain >>>> - PMU (Performance Monitoring Unit) >>>> - MSHC (Mobile Storage Host Controller) >>>> - PWM (Pluse Width Modulation) >>>> - AMBA bus >>>> >>>> Signed-off-by: Tomasz Figa >>>> Signed-off-by: Chanwoo Choi >>>> Signed-off-by: Kyungmin Park >>>> Signed-off-by: Inki Dae >>>> Signed-off-by: Hyunhee Kim >>>> Signed-off-by: Jaehoon Chung >>>> Signed-off-by: Bartlomiej Zolnierkiewicz >>>> Cc: Ben Dooks >>>> Cc: Kukjin Kim >>>> Cc: Rob Herring >>>> Cc: Pawel Moll >>>> Cc: Mark Rutland >>>> Cc: Ian Campbell >>>> Cc: Kumar Gala >>>> Cc: Russell King >>>> Cc: devicetree@vger.kernel.org >>>> --- >>>> arch/arm/boot/dts/exynos3250-pinctrl.dtsi | 477 +++++++++++++++ >>>> arch/arm/boot/dts/exynos3250.dtsi | 405 +++++++++++++ >>>> arch/arm/boot/dts/exynos4212-tizenw.dts | 926 >>>> ++++++++++++++++++++++++++++++ >>>> 3 files changed, 1808 insertions(+) >>>> create mode 100644 arch/arm/boot/dts/exynos3250-pinctrl.dtsi >>>> create mode 100644 arch/arm/boot/dts/exynos3250.dtsi >>>> create mode 100644 arch/arm/boot/dts/exynos4212-tizenw.dts >>>> >>>> diff --git a/arch/arm/boot/dts/exynos3250-pinctrl.dtsi >>>> b/arch/arm/boot/dts/exynos3250-pinctrl.dtsi >>>> new file mode 100644 >>>> index 0000000..976490b >>>> --- /dev/null >>>> +++ b/arch/arm/boot/dts/exynos3250-pinctrl.dtsi >>>> @@ -0,0 +1,477 @@ >>>> +/* >>>> + * Samsung's Exynos3250 SoCs pin-mux and pin-config device tree source >>>> + * >>>> + * Copyright (c) 2014 Samsung Electronics Co., Ltd. >>>> + * http://www.samsung.com >>>> + * >>>> + * Samsung's Exynos3250 SoCs pin-mux and pin-config optiosn are >>>> listed as device >>>> + * tree nodes are listed in this file. >>>> + * >>>> + * This program is free software; you can redistribute it and/or modify >>>> + * it under the terms of the GNU General Public License version 2 as >>>> + * published by the Free Software Foundation. >>>> +*/ >>>> + >>>> +/ { >>>> + pinctrl@11400000 { >>> >>> Could you use references instead of re-specifying the whole tree >>> hierarchy in every file a node is used? >>> >>> Instead of >>> >>> / { >>> pinctrl@11400000 { >>> >>> }; >>> }; >>> >>> one may simply use >>> >>> &pinctrl_0 { >>> >>> }; >>> >>> You might just need to change the location of #include >>> "exynos3250-pinctrl.dtsi" from top of exynos3250.dtsi to bottom of it. >> >> Oh, well, you also should move all nodes of on-SoC devices under a simple-bus node called soc. You can see the patch adding dts file for Exynos5260 for an example [1]. >> >> [1] http://thread.gmane.org/gmane.linux.kernel.samsung-soc/29360/focus=29361 > > > OK, I'll move nodes dependent on SoC under 'soc' dt node as example patch[1] except for 'amba-bus' dt node. I don't see any reason why amba-bus node shouldn't be under soc node as well. Any on-chip devices should be. Best regards, Tomasz