From: Tushar Behera <tushar.behera@linaro.org>
To: Tomasz Figa <tomasz.figa@gmail.com>, linux-samsung-soc@vger.kernel.org
Cc: kgene.kim@samsung.com, Sachin Kamat <sachin.kamat@linaro.org>
Subject: Re: [PATCH 1/2] ARM: EXYNOS: Add secure firmware support for Exynos5420
Date: Mon, 19 May 2014 17:40:34 +0530 [thread overview]
Message-ID: <5379F4BA.9040509@linaro.org> (raw)
In-Reply-To: <5379EBE4.9010704@gmail.com>
On 05/19/2014 05:02 PM, Tomasz Figa wrote:
> Hi Tushar, Sachin,
>
> On 19.05.2014 13:09, Tushar Behera wrote:
>> From: Sachin Kamat <sachin.kamat@linaro.org>
>>
>> Updated secondary boot register offset for Exynos5420 in case of
>> secure booting.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>> Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
>> ---
>>
>> The patches are based on top of next-20140519. With these two patches applied,
>> we can get all A15 cores booting up on Arndale-Octa board.
>>
>> arch/arm/mach-exynos/firmware.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/mach-exynos/firmware.c b/arch/arm/mach-exynos/firmware.c
>> index 739bdc8..5e0902e 100644
>> --- a/arch/arm/mach-exynos/firmware.c
>> +++ b/arch/arm/mach-exynos/firmware.c
>> @@ -50,7 +50,7 @@ static int exynos_set_cpu_boot_addr(int cpu, unsigned long boot_addr)
>>
>> boot_reg = sysram_ns_base_addr + 0x1c;
>>
>> - if (!soc_is_exynos4212())
>> + if (!soc_is_exynos4212() && !soc_is_exynos5420())
>> boot_reg += 4*cpu;
>
> I think it is safe to change this simply to if (soc_is_exynos4412()),
> since this seems to be the only SoC on which the firmware requires this
> offset.
>
> Best regards,
> Tomasz
>
Fair enough. Even Exynos3250 doesn't require this. I will resend this patch.
--
Tushar Behera
prev parent reply other threads:[~2014-05-19 12:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 11:09 [PATCH 1/2] ARM: EXYNOS: Add secure firmware support for Exynos5420 Tushar Behera
2014-05-19 11:09 ` [PATCH] ARM: dts: Add secure firmware support for Arndale-octa Tushar Behera
2014-05-19 11:32 ` [PATCH 1/2] ARM: EXYNOS: Add secure firmware support for Exynos5420 Tomasz Figa
2014-05-19 12:10 ` Tushar Behera [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5379F4BA.9040509@linaro.org \
--to=tushar.behera@linaro.org \
--cc=kgene.kim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox