From: Jaehoon Chung <jh80.chung@samsung.com>
To: Seungwon Jeon <tgih.jun@samsung.com>,
'Jaehoon Chung' <jh80.chung@samsung.com>,
linux-mmc@vger.kernel.org
Cc: chris@printf.net, ulf.hansson@linaro.org,
ludovic.desroches@atmel.com, devicetree@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, cpgs@samsung.com
Subject: Re: [PATCHv2 3/3] ARM: dts: replace the broken-cd property into slot node for dwmmc.
Date: Tue, 27 May 2014 19:08:47 +0900 [thread overview]
Message-ID: <5384642F.50406@samsung.com> (raw)
In-Reply-To: <002f01cf7990$fb20b530$f1621f90$%jun@samsung.com>
On 05/27/2014 06:49 PM, Seungwon Jeon wrote:
> Can this be merged with your another patch, " [PATCH 2/5] mmc: dw_mmc: remove the "supports-highspeed" property."?
Sure..
>
> On Mon, May 26, 2014, Jaehoon Chung wrote:
>> dw-mmc controller can be support the multiple slot.
> can support, it would be better to correct the above message.
Fix it.
Best Regards,
Jaehoon Chung
>
> Thanks,
> Seungwon Jeon
>
>> So each slot's property can be difference.
>>
>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>> ---
>> Changelog V2:
>> - None
>>
>> arch/arm/boot/dts/exynos4412-odroidx.dts | 2 +-
>> arch/arm/boot/dts/exynos4412-origen.dts | 2 +-
>> arch/arm/boot/dts/exynos4412-trats2.dts | 4 ++--
>> arch/arm/boot/dts/exynos5250-arndale.dts | 2 +-
>> arch/arm/boot/dts/exynos5250-cros-common.dtsi | 4 ++--
>> arch/arm/boot/dts/exynos5250-smdk5250.dts | 2 +-
>> arch/arm/boot/dts/exynos5420-arndale-octa.dts | 2 +-
>> arch/arm/boot/dts/rk3066a-bqcurie2.dts | 2 +-
>> arch/arm/boot/dts/socfpga_arria5.dtsi | 2 +-
>> arch/arm/boot/dts/socfpga_cyclone5.dtsi | 2 +-
>> arch/arm/boot/dts/socfpga_vt.dts | 2 +-
>> 11 files changed, 13 insertions(+), 13 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos4412-odroidx.dts b/arch/arm/boot/dts/exynos4412-odroidx.dts
>> index 31db28a..24ec351 100644
>> --- a/arch/arm/boot/dts/exynos4412-odroidx.dts
>> +++ b/arch/arm/boot/dts/exynos4412-odroidx.dts
>> @@ -46,7 +46,6 @@
>>
>> num-slots = <1>;
>> supports-highspeed;
>> - broken-cd;
>> card-detect-delay = <200>;
>> samsung,dw-mshc-ciu-div = <3>;
>> samsung,dw-mshc-sdr-timing = <2 3>;
>> @@ -55,6 +54,7 @@
>> slot@0 {
>> reg = <0>;
>> bus-width = <8>;
>> + broken-cd;
>> };
>> };
>>
>> diff --git a/arch/arm/boot/dts/exynos4412-origen.dts b/arch/arm/boot/dts/exynos4412-origen.dts
>> index e2c0dca..ed712a6 100644
>> --- a/arch/arm/boot/dts/exynos4412-origen.dts
>> +++ b/arch/arm/boot/dts/exynos4412-origen.dts
>> @@ -129,7 +129,6 @@
>>
>> num-slots = <1>;
>> supports-highspeed;
>> - broken-cd;
>> card-detect-delay = <200>;
>> samsung,dw-mshc-ciu-div = <3>;
>> samsung,dw-mshc-sdr-timing = <2 3>;
>> @@ -138,6 +137,7 @@
>> slot@0 {
>> reg = <0>;
>> bus-width = <8>;
>> + broken-cd;
>> };
>> };
>>
>> diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts b/arch/arm/boot/dts/exynos4412-trats2.dts
>> index 73be464..37c3cb3 100644
>> --- a/arch/arm/boot/dts/exynos4412-trats2.dts
>> +++ b/arch/arm/boot/dts/exynos4412-trats2.dts
>> @@ -460,8 +460,6 @@
>> mmc@12550000 {
>> num-slots = <1>;
>> supports-highspeed;
>> - broken-cd;
>> - non-removable;
>> card-detect-delay = <200>;
>> vmmc-supply = <&vemmc_reg>;
>> clock-frequency = <400000000>;
>> @@ -475,6 +473,8 @@
>> slot@0 {
>> reg = <0>;
>> bus-width = <8>;
>> + non-removable;
>> + broken-cd;
>> };
>> };
>>
>> diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts
>> index 090f983..0c9a7da 100644
>> --- a/arch/arm/boot/dts/exynos5250-arndale.dts
>> +++ b/arch/arm/boot/dts/exynos5250-arndale.dts
>> @@ -400,7 +400,6 @@
>> status = "okay";
>> num-slots = <1>;
>> supports-highspeed;
>> - broken-cd;
>> card-detect-delay = <200>;
>> samsung,dw-mshc-ciu-div = <3>;
>> samsung,dw-mshc-sdr-timing = <2 3>;
>> @@ -412,6 +411,7 @@
>> slot@0 {
>> reg = <0>;
>> bus-width = <8>;
>> + broken-cd;
>> };
>> };
>>
>> diff --git a/arch/arm/boot/dts/exynos5250-cros-common.dtsi b/arch/arm/boot/dts/exynos5250-cros-
>> common.dtsi
>> index 2c1560d..7ab3b94 100644
>> --- a/arch/arm/boot/dts/exynos5250-cros-common.dtsi
>> +++ b/arch/arm/boot/dts/exynos5250-cros-common.dtsi
>> @@ -249,7 +249,6 @@
>> mmc@12200000 {
>> num-slots = <1>;
>> supports-highspeed;
>> - broken-cd;
>> card-detect-delay = <200>;
>> samsung,dw-mshc-ciu-div = <3>;
>> samsung,dw-mshc-sdr-timing = <2 3>;
>> @@ -260,6 +259,7 @@
>> slot@0 {
>> reg = <0>;
>> bus-width = <8>;
>> + broken-cd;
>> };
>> };
>>
>> @@ -283,7 +283,6 @@
>> mmc@12230000 {
>> num-slots = <1>;
>> supports-highspeed;
>> - broken-cd;
>> card-detect-delay = <200>;
>> samsung,dw-mshc-ciu-div = <3>;
>> samsung,dw-mshc-sdr-timing = <2 3>;
>> @@ -293,6 +292,7 @@
>> slot@0 {
>> reg = <0>;
>> bus-width = <4>;
>> + broken-cd;
>> };
>> };
>>
>> diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts
>> index a794a70..feffe24 100644
>> --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
>> +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
>> @@ -283,7 +283,6 @@
>> status = "okay";
>> num-slots = <1>;
>> supports-highspeed;
>> - broken-cd;
>> card-detect-delay = <200>;
>> samsung,dw-mshc-ciu-div = <3>;
>> samsung,dw-mshc-sdr-timing = <2 3>;
>> @@ -294,6 +293,7 @@
>> slot@0 {
>> reg = <0>;
>> bus-width = <8>;
>> + broken-cd;
>> };
>> };
>>
>> diff --git a/arch/arm/boot/dts/exynos5420-arndale-octa.dts b/arch/arm/boot/dts/exynos5420-arndale-
>> octa.dts
>> index 80a3bf4..0d3b467 100644
>> --- a/arch/arm/boot/dts/exynos5420-arndale-octa.dts
>> +++ b/arch/arm/boot/dts/exynos5420-arndale-octa.dts
>> @@ -39,7 +39,6 @@
>>
>> mmc@12200000 {
>> status = "okay";
>> - broken-cd;
>> supports-highspeed;
>> card-detect-delay = <200>;
>> samsung,dw-mshc-ciu-div = <3>;
>> @@ -52,6 +51,7 @@
>> slot@0 {
>> reg = <0>;
>> bus-width = <8>;
>> + broken-cd;
>> };
>> };
>>
>> diff --git a/arch/arm/boot/dts/rk3066a-bqcurie2.dts b/arch/arm/boot/dts/rk3066a-bqcurie2.dts
>> index 035df40..62c7484 100644
>> --- a/arch/arm/boot/dts/rk3066a-bqcurie2.dts
>> +++ b/arch/arm/boot/dts/rk3066a-bqcurie2.dts
>> @@ -69,7 +69,6 @@
>> dwmmc@10218000 { /* wifi */
>> num-slots = <1>;
>> status = "okay";
>> - non-removable;
>>
>> pinctrl-names = "default";
>> pinctrl-0 = <&sd1_clk &sd1_cmd &sd1_bus4>;
>> @@ -78,6 +77,7 @@
>> reg = <0>;
>> bus-width = <4>;
>> disable-wp;
>> + non-removable;
>> };
>> };
>>
>> diff --git a/arch/arm/boot/dts/socfpga_arria5.dtsi b/arch/arm/boot/dts/socfpga_arria5.dtsi
>> index 6c87b70..9c2b933 100644
>> --- a/arch/arm/boot/dts/socfpga_arria5.dtsi
>> +++ b/arch/arm/boot/dts/socfpga_arria5.dtsi
>> @@ -30,11 +30,11 @@
>> dwmmc0@ff704000 {
>> num-slots = <1>;
>> supports-highspeed;
>> - broken-cd;
>>
>> slot@0 {
>> reg = <0>;
>> bus-width = <4>;
>> + broken-cd;
>> };
>> };
>>
>> diff --git a/arch/arm/boot/dts/socfpga_cyclone5.dtsi b/arch/arm/boot/dts/socfpga_cyclone5.dtsi
>> index ca41b0e..c5c7b5f 100644
>> --- a/arch/arm/boot/dts/socfpga_cyclone5.dtsi
>> +++ b/arch/arm/boot/dts/socfpga_cyclone5.dtsi
>> @@ -31,11 +31,11 @@
>> dwmmc0@ff704000 {
>> num-slots = <1>;
>> supports-highspeed;
>> - broken-cd;
>>
>> slot@0 {
>> reg = <0>;
>> bus-width = <4>;
>> + broken-cd;
>> };
>> };
>>
>> diff --git a/arch/arm/boot/dts/socfpga_vt.dts b/arch/arm/boot/dts/socfpga_vt.dts
>> index 87d6f75..ff1111e 100644
>> --- a/arch/arm/boot/dts/socfpga_vt.dts
>> +++ b/arch/arm/boot/dts/socfpga_vt.dts
>> @@ -44,11 +44,11 @@
>> dwmmc0@ff704000 {
>> num-slots = <1>;
>> supports-highspeed;
>> - broken-cd;
>>
>> slot@0 {
>> reg = <0>;
>> bus-width = <4>;
>> + broken-cd;
>> };
>> };
>>
>> --
>> 1.7.9.5
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2014-05-27 10:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-26 11:35 [PATCHv2 0/3] mmc: fixed the mmc_of_parse for dwmmc Jaehoon Chung
2014-05-26 11:35 ` [PATCHv2 1/3] mmc: host: add slot argument to mmc_of_parse Jaehoon Chung
2014-05-26 14:37 ` Ulf Hansson
2014-05-27 9:48 ` Seungwon Jeon
2014-05-26 11:35 ` [PATCHv2 2/3] mmc: dw_mmc: use the __mmc_of_parse to parse the slot node Jaehoon Chung
2014-05-27 9:49 ` Seungwon Jeon
2014-05-27 10:07 ` Jaehoon Chung
2014-05-26 11:35 ` [PATCHv2 3/3] ARM: dts: replace the broken-cd property into slot node for dwmmc Jaehoon Chung
2014-05-27 9:49 ` Seungwon Jeon
2014-05-27 10:08 ` Jaehoon Chung [this message]
2014-05-27 10:38 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5384642F.50406@samsung.com \
--to=jh80.chung@samsung.com \
--cc=chris@printf.net \
--cc=cpgs@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=ludovic.desroches@atmel.com \
--cc=tgih.jun@samsung.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox