From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Tushar Behera <trblinux@gmail.com>, Tushar Behera <tushar.b@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com
Subject: Re: [PATCH] ARM: dts: Add missing clock/pin-control entries for I2S0 on Exynos4
Date: Mon, 16 Jun 2014 13:50:56 +0200 [thread overview]
Message-ID: <539EDA20.7090607@samsung.com> (raw)
In-Reply-To: <539ED85E.8050002@gmail.com>
On 16/06/14 13:43, Tushar Behera wrote:
> On 06/09/2014 04:36 PM, Sylwester Nawrocki wrote:
>> > On 09/06/14 12:44, Tushar Behera wrote:
>>> >> IMHO, the clock entries belong here as the audss clock provider
>>> >> essentially remains same for all Exynos4 based systems.
>>> >>
>>> >> As for pin-control entry, I believe we can move them to respective SoC
>>> >> dtsi files.
>>> >>
>>> >> Does that sound okay to you?
>> >
>> > I guess that's fine, I tend to agree with you about the clocks.
>> >
> As I was going ahead with the implementation, it felt like repetition
> with the same code. Would it be acceptable to you if we go ahead with
> the earlier approach of adding both clock and pin-control entry to
> exynos4.dtsi?
>
> I can see i2c_n and spi_n adding pin-control entries in exynos4.dtsi itself.
OK, I don't mind, I'll leave it up to the maintainers.
--
Regards,
Sylwester
next prev parent reply other threads:[~2014-06-16 11:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-07 9:30 [PATCH] ARM: dts: Add missing clock/pin-control entries for I2S0 on Exynos4 Tushar Behera
2014-06-09 9:53 ` Sylwester Nawrocki
2014-06-09 10:44 ` Tushar Behera
2014-06-09 11:06 ` Sylwester Nawrocki
2014-06-16 11:43 ` Tushar Behera
2014-06-16 11:50 ` Sylwester Nawrocki [this message]
2014-06-16 12:03 ` Tushar Behera
2014-06-16 12:24 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539EDA20.7090607@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=trblinux@gmail.com \
--cc=tushar.b@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox