Linux Samsung SOC development
 help / color / mirror / Atom feed
From: Tomasz Figa <tomasz.figa@gmail.com>
To: Daniel Drake <drake@endlessm.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
	Kukjin Kim <kgene.kim@samsung.com>,
	Kamil Debski <k.debski@samsung.com>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Tobias Jakobi <Liquid.Acid@gmx.net>
Subject: Re: [PATCH 2/4] ARM: dts: exynos4412-odroidx: enable common hardware blocks
Date: Thu, 19 Jun 2014 15:08:34 +0200	[thread overview]
Message-ID: <53A2E0D2.5010200@gmail.com> (raw)
In-Reply-To: <CAD8Lp46az1w9K8ad-KOrnt1SvCgWS75OGjCw1vBNh3HOc4cSMg@mail.gmail.com>

On 19.06.2014 14:21, Daniel Drake wrote:
> On Tue, Jun 17, 2014 at 10:25 AM, Marek Szyprowski
> <m.szyprowski@samsung.com> wrote:
>> This patch adds support for common hardware modules available on all
>> Exynos4412-based Odroid boards, which already have complete support in
>> mainline kernel. This includes secure firmware calls, watchdog, g2d and
>> fimc (mem2mem) multimedia accelerators.
> 
> For the secure firmware, this is indeed required for U2/U3, otherwise
> the system crashes in weird ways during early boot. If this entry also
> makes sense for ODROID-X, I'm surprised it was not there already, does
> it boot without it?

It probably does, but certain things fail, such as secondary CPU bring-up.

> 
> As for the watchdog, g2d and fimc, is there really any Exynos4412
> configuration where such components are not available?
> Sorry if that is a silly question - just wondering why we wouldn't
> enable these in exynos4412.dtsi.

I believe they should all be enabled at highest possible level, as they
don't have any board-specific hardware dependencies. Probably even in
exynos4.dtsi for some of them (watchdog likely).

Best regards,
Tomasz

  reply	other threads:[~2014-06-19 13:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-17  9:25 [PATCH 0/4] Add Exynos4412 based Odroid X2 and U2/U3/U3+ support Marek Szyprowski
2014-06-17  9:25 ` [PATCH 1/4] ARM: dts: exynos4: add port sub-nodes to exynos usb host modules Marek Szyprowski
2014-06-19 11:44   ` Daniel Drake
2014-06-19 13:12     ` Tomasz Figa
2014-06-17  9:25 ` [PATCH 2/4] ARM: dts: exynos4412-odroidx: enable common hardware blocks Marek Szyprowski
2014-06-19 12:21   ` Daniel Drake
2014-06-19 13:08     ` Tomasz Figa [this message]
2014-06-17  9:25 ` [PATCH 3/4] ARM: dts: exynos4412-odroidx: add support for USB (phy, host, device) Marek Szyprowski
2014-06-19 12:32   ` Daniel Drake
2014-06-17  9:25 ` [PATCH 4/4] ARM: dts: refactor Odroid DTS file and add support for Odroid X2 and U2/U3 Marek Szyprowski
2014-06-19 12:43   ` Daniel Drake
2014-06-24 11:47     ` Marek Szyprowski
2014-06-25 22:15       ` Tomasz Figa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53A2E0D2.5010200@gmail.com \
    --to=tomasz.figa@gmail.com \
    --cc=Liquid.Acid@gmx.net \
    --cc=drake@endlessm.com \
    --cc=k.debski@samsung.com \
    --cc=kgene.kim@samsung.com \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=s.nawrocki@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox