Linux Samsung SOC development
 help / color / mirror / Atom feed
From: Kukjin Kim <kgene.kim@samsung.com>
To: Doug Anderson <dianders@chromium.org>
Cc: Tushar Behera <tushar.b@samsung.com>,
	Kukjin Kim <kgene.kim@samsung.com>,
	linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
	"broonie@kernel.org" <broonie@kernel.org>,
	Tushar Behera <trblinux@gmail.com>
Subject: Re: [PATCH 2/2] ARM: dts: Sort nodes within Peach-pit/Peach-pi dts files
Date: Sat, 21 Jun 2014 21:51:32 +0900	[thread overview]
Message-ID: <53A57FD4.7050003@samsung.com> (raw)
In-Reply-To: <CAD=FV=X1EJ4HFQcSR2nBZTnmpOaKRkEy04d21LBSKS3Vj1XAUA@mail.gmail.com>

On 06/21/14 05:09, Doug Anderson wrote:
> Tushar / Kukjin,
>
> On Fri, Jun 20, 2014 at 1:20 AM, Tushar Behera<tushar.b@samsung.com>  wrote:
>> Peach-pit and Peach-pi boards are almost similar, hence the DTS file
>> is also very similar. Sorting nodes in both these files will allow
>> us to figure out the difference easily.
>>
>> All the node aliases are sorted in alphabetically increasing order.
>> There is no functional change with this patch.
>>
>> Signed-off-by: Tushar Behera<tushar.b@samsung.com>
>> ---
>>   arch/arm/boot/dts/exynos5420-peach-pit.dts |  236 ++++++++++++++--------------
>>   arch/arm/boot/dts/exynos5800-peach-pi.dts  |  225 +++++++++++++-------------
>>   2 files changed, 233 insertions(+), 228 deletions(-)
>
> Thanks, this looks much better.  I tried against next-20140620 and it
> applied cleanly, gave a good diff between pit and pi, and looked sane.
>
> This is gonna be a pain in the butt if Kukjin doesn't apply it ASAP.
> It will conflict with every single other dts patch to pi.
>
So I've applied both in my tree just now ;-)

> Reviewed-by: Doug Anderson<dianders@chromium.org>

Thanks for your review.

- Kukjin

      reply	other threads:[~2014-06-21 12:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-20  8:20 [PATCH v2 0/2] ARM: dts: Peach-pi audio support and cleanup Tushar Behera
2014-06-20  8:20 ` [PATCH v2 1/2] ARM: dts: Enable audio support for Peach-pi board Tushar Behera
2014-06-20 20:10   ` Doug Anderson
2014-06-20  8:20 ` [PATCH 2/2] ARM: dts: Sort nodes within Peach-pit/Peach-pi dts files Tushar Behera
2014-06-20 20:09   ` Doug Anderson
2014-06-21 12:51     ` Kukjin Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53A57FD4.7050003@samsung.com \
    --to=kgene.kim@samsung.com \
    --cc=broonie@kernel.org \
    --cc=dianders@chromium.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=trblinux@gmail.com \
    --cc=tushar.b@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox