From: Joonyoung Shim <jy0922.shim@samsung.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>,
Tobias Jakobi <liquid.acid@gmx.net>,
linux-samsung-soc@vger.kernel.org,
dri-devel@lists.freedesktop.org
Cc: Tomasz Stanislawski <t.stanislaws@samsung.com>,
Kukjin Kim <kgene.kim@samsung.com>,
Daniel Drake <drake@endlessm.com>,
Andrzej Hajda <a.hajda@samsung.com>
Subject: Re: [PATCH 4/7] Exynos: add support for 'domain-always-on' property
Date: Wed, 02 Jul 2014 16:28:41 +0900 [thread overview]
Message-ID: <53B3B4A9.6060307@samsung.com> (raw)
In-Reply-To: <53B27AA3.5030000@samsung.com>
Hi Marek,
On 07/01/2014 06:08 PM, Marek Szyprowski wrote:
> Hello,
>
> On 2014-07-01 10:52, Tobias Jakobi wrote:
>> Hello Marek,
>>
>> I think you had a similar patch in the tizen tree, but according to
>> Tomasz Figa, it was considered a hack. I don't quite see how this is
>> different.
>>
>> Also, if I have been following the discussion correctly, then the
>> powerdomain issue essentially is about the question which SoC block
>> needs the LCD0 domain and how the proper power on/off sequences should
>> look like.
>>
>> At least the mixer power issue, which I pointed out some time ago, seems
>> to be deal with now:
>> https://git.kernel.org/cgit/linux/kernel/git/daeinki/drm-exynos.git/commit/?h=exynos-drm-next&id=381be025ac1a6dc8efebdf146ced0d4a6007f77b
>>
>
> Well, that patch solves power on/off sequence issue with mixer and hdmi,
> but it didn't solve the issue with additional managing of power domain
> on/off. You can check that if you remove always on property, system will
> freeze when hdmi cable is connected for the second time. I've
> investigated
> it for some time, but right now I didn't find any 100% reliable solution
> other than keeping the power domain enabled all the time. At least for
> now, this patch lets you use HDMI without any stability issues.
>
> I've only found that there are still at least 2 issues with power
> domains.
> One is Mixer/Video Processor dependency on LCD0 domain, second is the
> proper
To express dependency of LCD0 domain and TV domain, how about make
master and slave hierarchy between the pm domains using
pm_genpd_add_subdomain?
> power on/off sequence of HDMI/Mixer and TV domain. Forcing both
> domains to
> 'always on' workarounds both issues for now. Right now I have no better
> idea.
>
> Later, once the proper sequence is found we can remove those properties
> from Odroid DTS.
>
> Best regards
next prev parent reply other threads:[~2014-07-02 7:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 8:10 [PATCH 0/7] Exynos4: enable HDMI support for Odroid and UniversalC210 Marek Szyprowski
2014-07-01 8:10 ` [PATCH 1/7] clk: exynos4: add support for MOUT_HDMI and MOUT_MIXER clocks Marek Szyprowski
2014-07-01 8:46 ` Tobias Jakobi
2014-07-01 8:57 ` Marek Szyprowski
2014-07-01 17:44 ` Tobias Jakobi
2014-07-01 8:10 ` [PATCH 2/7] drm: exynos: hdmi: make 'hdmi-en' regulator optional and keep it enabled Marek Szyprowski
2014-07-01 8:10 ` [PATCH 3/7] drm: hdmi/mixer: enable exynos 4210 and 4x12 soc support Marek Szyprowski
2014-07-01 8:10 ` [PATCH 4/7] Exynos: add support for 'domain-always-on' property Marek Szyprowski
2014-07-01 8:52 ` Tobias Jakobi
2014-07-01 9:08 ` Marek Szyprowski
2014-07-01 17:54 ` Tobias Jakobi
2014-07-02 7:56 ` Marek Szyprowski
2014-07-02 7:28 ` Joonyoung Shim [this message]
2014-07-01 8:10 ` [PATCH 5/7] ARM: dts: exynos4: add hdmi related nodes Marek Szyprowski
2014-07-01 8:10 ` [PATCH 6/7] ARM: dts: exynos4412-odroid: enable hdmi support Marek Szyprowski
2014-07-01 8:10 ` [PATCH 7/7] ARM: dts: exynos4210-universal_c210: " Marek Szyprowski
2014-07-19 10:40 ` [PATCH 0/7] Exynos4: enable HDMI support for Odroid and UniversalC210 Inki Dae
2014-08-12 13:00 ` Tomeu Vizoso
2014-08-26 13:03 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B3B4A9.6060307@samsung.com \
--to=jy0922.shim@samsung.com \
--cc=a.hajda@samsung.com \
--cc=drake@endlessm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kgene.kim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=liquid.acid@gmx.net \
--cc=m.szyprowski@samsung.com \
--cc=t.stanislaws@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox