From: Tomasz Figa <tomasz.figa@gmail.com>
To: Sachin Kamat <sachin.kamat@samsung.com>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>
Cc: Kukjin Kim <kgene.kim@samsung.com>
Subject: Re: [PATCH 1/1] ARM: EXYNOS: Remove unused code in common.h
Date: Fri, 04 Jul 2014 10:33:39 +0200 [thread overview]
Message-ID: <53B666E3.4090106@gmail.com> (raw)
In-Reply-To: <CAK5sBcFjTMjTG=+gAdKh77q=vrRqonfZDe_vJEkyOkE9W0FK7g@mail.gmail.com>
Hi Sachin,
On 04.07.2014 10:29, Sachin Kamat wrote:
> On Mon, Jun 23, 2014 at 5:30 PM, Sachin Kamat <sachin.kamat@samsung.com> wrote:
>> PINCTRL_EXYNOS is always selected by Exynos platform in its
>> machine Kconfig. Thus the code in the else part is never used.
>> Remove it.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
>> ---
>> arch/arm/mach-exynos/common.h | 4 ----
>> 1 file changed, 4 deletions(-)
>>
>> diff --git a/arch/arm/mach-exynos/common.h b/arch/arm/mach-exynos/common.h
>> index 1ee91763fa7c..3371669dabc6 100644
>> --- a/arch/arm/mach-exynos/common.h
>> +++ b/arch/arm/mach-exynos/common.h
>> @@ -125,11 +125,7 @@ void exynos_init_late(void);
>>
>> void exynos_firmware_init(void);
>>
>> -#ifdef CONFIG_PINCTRL_EXYNOS
>> extern u32 exynos_get_eint_wake_mask(void);
>> -#else
>> -static inline u32 exynos_get_eint_wake_mask(void) { return 0xffffffff; }
>> -#endif
>>
>> #ifdef CONFIG_PM_SLEEP
>> extern void __init exynos_pm_init(void);
>> --
>> 1.7.9.5
>>
>
> Ping..
>
For this change alone:
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
However I can see much more unused code in that header, more
specifically prototypes of mct_init() (replaced with DT-based init) and
most of other *init*() functions (which are now all in one file). Do you
plan to remove them as well?
Best regards,
Tomasz
next prev parent reply other threads:[~2014-07-04 8:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-23 12:00 [PATCH 1/1] ARM: EXYNOS: Remove unused code in common.h Sachin Kamat
2014-07-04 8:29 ` Sachin Kamat
2014-07-04 8:33 ` Tomasz Figa [this message]
2014-07-04 8:43 ` Sachin Kamat
2014-07-04 8:55 ` Sachin Kamat
2014-07-04 21:53 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B666E3.4090106@gmail.com \
--to=tomasz.figa@gmail.com \
--cc=kgene.kim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sachin.kamat@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox