Re: [PATCH] drm/exynos: dsi: fix exynos_dsi_set_pll() wrong return value

From: Inki Dae <inki.dae@samsung.com>
To: YoungJun Cho <yj44.cho@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org, sw0312.kim@samsung.com,
	dri-devel@lists.freedesktop.org, a.hajda@samsung.com,
	kyungmin.park@samsung.com, kgene.kim@samsung.com
Subject: Re: [PATCH] drm/exynos: dsi: fix exynos_dsi_set_pll() wrong return value
Date: Mon, 18 Aug 2014 17:32:36 +0900	[thread overview]
Message-ID: <53F1BA24.6000102@samsung.com> (raw)
In-Reply-To: <1407982956-18923-1-git-send-email-yj44.cho@samsung.com>

On 2014년 08월 14일 11:22, YoungJun Cho wrote:
> The type of this function is unsigned long, and it is expected
> to return proper fout value or zero if something is wrong.
> So this patch fixes wrong return value for error cases.

Applied.

Thanks,
Inki Dae

> 
> Signed-off-by: YoungJun Cho <yj44.cho@samsung.com>
> Acked-by: Inki Dae <inki.dae@samsung.com>
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
>  drivers/gpu/drm/exynos/exynos_drm_dsi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> index 86aebd8..061017b 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> @@ -421,7 +421,7 @@ static unsigned long exynos_dsi_set_pll(struct exynos_dsi *dsi,
>  	if (!fout) {
>  		dev_err(dsi->dev,
>  			"failed to find PLL PMS for requested frequency\n");
> -		return -EFAULT;
> +		return 0;
>  	}
>  	dev_dbg(dsi->dev, "PLL freq %lu, (p %d, m %d, s %d)\n", fout, p, m, s);
>  
> @@ -453,7 +453,7 @@ static unsigned long exynos_dsi_set_pll(struct exynos_dsi *dsi,
>  	do {
>  		if (timeout-- == 0) {
>  			dev_err(dsi->dev, "PLL failed to stabilize\n");
> -			return -EFAULT;
> +			return 0;
>  		}
>  		reg = readl(dsi->reg_base + DSIM_STATUS_REG);
>  	} while ((reg & DSIM_PLL_STABLE) == 0);
> 

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel