Re: [PATCH 1/5] drm/exynos: mipi-dsi: add Exynos3 SoC support

[Andrzej Hajda <a.hajda@samsung.com>]

On 08/18/2014 10:21 AM, Inki Dae wrote:
> This patch adds Exynos3250/3472 SoCs support.
>
> Signed-off-by: Inki Dae <inki.dae@samsung.com>
Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
--
Regards
Andrzej
> ---
>  .../devicetree/bindings/video/exynos_dsim.txt      |    1 +
>  drivers/gpu/drm/exynos/exynos_drm_dsi.c            |    8 ++++++++
>  2 files changed, 9 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/video/exynos_dsim.txt b/Documentation/devicetree/bindings/video/exynos_dsim.txt
> index 31036c6..e74243b 100644
> --- a/Documentation/devicetree/bindings/video/exynos_dsim.txt
> +++ b/Documentation/devicetree/bindings/video/exynos_dsim.txt
> @@ -2,6 +2,7 @@ Exynos MIPI DSI Master
>  
>  Required properties:
>    - compatible: value should be one of the following
> +		"samsung,exynos3250-mipi-dsi" /* for Exynos3250/3472 SoCs */
>  		"samsung,exynos4210-mipi-dsi" /* for Exynos4 SoCs */
>  		"samsung,exynos5410-mipi-dsi" /* for Exynos5410/5420/5440 SoCs */
>    - reg: physical base address and length of the registers set for the device
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> index 9a186c0..a8c0c4f 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c
> @@ -304,6 +304,12 @@ struct exynos_dsi {
>  #define host_to_dsi(host) container_of(host, struct exynos_dsi, dsi_host)
>  #define connector_to_dsi(c) container_of(c, struct exynos_dsi, connector)
>  
> +static struct exynos_dsi_driver_data exynos3_dsi_driver_data = {
> +	.plltmr_reg = 0x50,
> +	.has_freqband = 1,
> +	.has_clklane_stop = 1,
> +};
> +
>  static struct exynos_dsi_driver_data exynos4_dsi_driver_data = {
>  	.plltmr_reg = 0x50,
>  	.has_freqband = 1,
> @@ -315,6 +321,8 @@ static struct exynos_dsi_driver_data exynos5_dsi_driver_data = {
>  };
>  
>  static struct of_device_id exynos_dsi_of_match[] = {
> +	{ .compatible = "samsung,exynos3250-mipi-dsi",
> +	  .data = &exynos3_dsi_driver_data },
>  	{ .compatible = "samsung,exynos4210-mipi-dsi",
>  	  .data = &exynos4_dsi_driver_data },
>  	{ .compatible = "samsung,exynos5410-mipi-dsi",