Re: [PATCH 2/2] input: cros_ec_keyb: Add of match table

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

Hello.

On 8/23/2014 3:03 AM, Sjoerd Simons wrote:

> To enable the cros_ec_keyb driver to be auto-loaded when build as
> module add an of match table (and export it) to match the modalias
> information passed on to userspace as the Cros EC MFD driver registers
> the MFD subdevices with an of_compatibility string.

> Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
> ---
>   drivers/input/keyboard/cros_ec_keyb.c | 10 ++++++++++
>   1 file changed, 10 insertions(+)

> diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c
> index 791781a..0bdbf2d 100644
> --- a/drivers/input/keyboard/cros_ec_keyb.c
> +++ b/drivers/input/keyboard/cros_ec_keyb.c
> @@ -342,10 +342,20 @@ static int cros_ec_keyb_resume(struct device *dev)
>
>   static SIMPLE_DEV_PM_OPS(cros_ec_keyb_pm_ops, NULL, cros_ec_keyb_resume);
>
> +#ifdef CONFIG_OF
> +static const struct of_device_id cros_ec_keyb_of_match[] = {

    Perhaps better to use '__maybe_unused' instead of #ifdef...

> +	{ .compatible = "google,cros-ec-keyb" },
> +	{},
> +};
> +MODULE_DEVICE_TABLE(of, cros_ec_keyb_of_match);
> +#endif
> +
> +

    Too many empty lines.

>   static struct platform_driver cros_ec_keyb_driver = {
>   	.probe = cros_ec_keyb_probe,
>   	.driver = {
>   		.name = "cros-ec-keyb",
> +		.of_match_table = of_match_ptr (cros_ec_keyb_of_match),

    There shouldn't be space before (.

>   		.pm	= &cros_ec_keyb_pm_ops,
>   	},
>   };

WBR, Sergei