From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Pankaj Dubey <pankaj.dubey@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com,
tomasz.figa@gmail.com, linux@arm.linux.org.uk,
thomas.ab@samsung.com, linux@roeck-us.net
Subject: Re: [PATCH v5 2/2] ARM: EXYNOS: PMU: move restart code into pmu driver
Date: Tue, 18 Nov 2014 16:19:49 +0100 [thread overview]
Message-ID: <546B6395.8020403@samsung.com> (raw)
In-Reply-To: <1416307650-15162-3-git-send-email-pankaj.dubey@samsung.com>
On 18/11/14 11:47, Pankaj Dubey wrote:
> diff --git a/arch/arm/mach-exynos/pmu.c b/arch/arm/mach-exynos/pmu.c
> index 6c8a76d..e4c3512 100644
> --- a/arch/arm/mach-exynos/pmu.c
> +++ b/arch/arm/mach-exynos/pmu.c
> @@ -11,8 +11,11 @@
> @@ -716,6 +719,13 @@ static void exynos5420_pmu_init(void)
> pr_info("EXYNOS5420 PMU initialized\n");
> }
>
> +static int pmu_restart_notify(struct notifier_block *this,
> + unsigned long code, void *unused)
> +{
> + pmu_raw_writel(0x1, EXYNOS_SWRESET);
Is it also valid on exynos5440 ? Doesn't it cause any harm there ?
Perhaps we could add a comment saying it has not effect on that SoC ?
> + return NOTIFY_DONE;
> +}
--
Thanks,
Sylwester
next prev parent reply other threads:[~2014-11-18 15:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-18 10:47 [PATCH v5 0/2] Handle reboot for Exynos SoC via restart_handler Pankaj Dubey
2014-11-18 10:47 ` [PATCH v5 1/2] clk: samsung: exynos5440: move restart code into clock driver Pankaj Dubey
2014-11-18 15:17 ` Sylwester Nawrocki
2014-11-19 3:37 ` Pankaj Dubey
2014-11-20 17:48 ` Sylwester Nawrocki
2014-11-21 10:30 ` Pankaj Dubey
2014-11-22 2:08 ` Kukjin Kim
2014-11-24 2:16 ` amit daniel kachhap
2014-11-18 10:47 ` [PATCH v5 2/2] ARM: EXYNOS: PMU: move restart code into pmu driver Pankaj Dubey
2014-11-18 15:19 ` Sylwester Nawrocki [this message]
2014-11-19 3:16 ` Pankaj Dubey
2014-11-19 14:26 ` Sylwester Nawrocki
2014-11-21 4:28 ` Vivek Gautam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546B6395.8020403@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linux@roeck-us.net \
--cc=pankaj.dubey@samsung.com \
--cc=thomas.ab@samsung.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox