From: Chanwoo Choi <cw00.choi@samsung.com>
To: Beomho Seo <beomho.seo@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
kgene.kim@samsung.com, yj44.cho@samsung.com,
inki.dae@samsung.com, sw0312.kim@samsung.com,
jh80.chung@samsung.com, kyungmin.park@samsung.com
Subject: Re: [PATCH 2/2] ARM: dts: exynos3250: replace number by macro in gpio keys
Date: Fri, 19 Dec 2014 17:41:40 +0900 [thread overview]
Message-ID: <5493E4C4.8080208@samsung.com> (raw)
In-Reply-To: <1418978370-22542-2-git-send-email-beomho.seo@samsung.com>
Hi Beomho,
On 12/19/2014 05:39 PM, Beomho Seo wrote:
> This patch replace number by macro in gpio keys for exynos 3250 boards.
>
> Cc: Youngjun Cho <yj44.cho@samsung.com>
> Cc: Chanwoo Choi <cw00.choi@samsung.com>
> Signed-off-by: Beomho Seo <beomho.seo@samsung.com>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Thanks,
Chanwoo CHoi
> ---
> arch/arm/boot/dts/exynos3250-monk.dts | 3 ++-
> arch/arm/boot/dts/exynos3250-rinato.dts | 3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos3250-monk.dts b/arch/arm/boot/dts/exynos3250-monk.dts
> index 2129ab98..792a2c7 100644
> --- a/arch/arm/boot/dts/exynos3250-monk.dts
> +++ b/arch/arm/boot/dts/exynos3250-monk.dts
> @@ -15,6 +15,7 @@
> /dts-v1/;
> #include "exynos3250.dtsi"
> #include <dt-bindings/input/input.h>
> +#include <dt-bindings/gpio/gpio.h>
>
> / {
> model = "Samsung Monk board";
> @@ -37,7 +38,7 @@
> compatible = "gpio-keys";
>
> power_key {
> - gpios = <&gpx2 7 1>;
> + gpios = <&gpx2 7 GPIO_ACTIVE_LOW>;
> linux,code = <KEY_POWER>;
> label = "power key";
> debounce-interval = <10>;
> diff --git a/arch/arm/boot/dts/exynos3250-rinato.dts b/arch/arm/boot/dts/exynos3250-rinato.dts
> index c186ac6..3493bca 100644
> --- a/arch/arm/boot/dts/exynos3250-rinato.dts
> +++ b/arch/arm/boot/dts/exynos3250-rinato.dts
> @@ -15,6 +15,7 @@
> /dts-v1/;
> #include "exynos3250.dtsi"
> #include <dt-bindings/input/input.h>
> +#include <dt-bindings/gpio/gpio.h>
>
> / {
> model = "Samsung Rinato board";
> @@ -37,7 +38,7 @@
> compatible = "gpio-keys";
>
> power_key {
> - gpios = <&gpx2 7 1>;
> + gpios = <&gpx2 7 GPIO_ACTIVE_LOW>;
> linux,code = <KEY_POWER>;
> label = "power key";
> debounce-interval = <10>;
>
next prev parent reply other threads:[~2014-12-19 8:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-19 8:39 [PATCH 1/2] ARM: dts: exynos3250: remove unecessary property of gpio-keys node Beomho Seo
2014-12-19 8:39 ` [PATCH 2/2] ARM: dts: exynos3250: replace number by macro in gpio keys Beomho Seo
2014-12-19 8:41 ` Chanwoo Choi [this message]
2014-12-19 8:41 ` [PATCH 1/2] ARM: dts: exynos3250: remove unecessary property of gpio-keys node Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5493E4C4.8080208@samsung.com \
--to=cw00.choi@samsung.com \
--cc=beomho.seo@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=inki.dae@samsung.com \
--cc=jh80.chung@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sw0312.kim@samsung.com \
--cc=yj44.cho@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox