Linux Samsung SOC development
 help / color / mirror / Atom feed
From: Javier Martinez Canillas <javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
To: Andrzej Hajda <a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Marek Szyprowski
	<m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	Kyungmin Park
	<kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>,
	Kukjin Kim <kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Liquid.Acid-hi6Y0CQ0nG0@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [RFC PATCH 0/3] Fix power domains handling on exynos542x
Date: Thu, 05 Feb 2015 15:45:08 +0100	[thread overview]
Message-ID: <54D381F4.2080701@collabora.co.uk> (raw)
In-Reply-To: <1423139739-19881-1-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>

Hello Andrzej,

Thanks a lot for finally finding what was causing the HDMI issue.

On 02/05/2015 01:35 PM, Andrzej Hajda wrote:
> Hi,
> 
> Exynos chipsets since 542x have asynchronous bridges connecting different IPs.
> These bridges should be operational during power domain switching, ie associated
> clocks cannot be gated.
> This patchset adds binding to provide such clocks per power domain and adds code
> which enables them during domain on/off operation.
> 
> This patchset fixes power domain issues with disp1 domain and HDMI (some of them)
> on Odroid XU3:
> - disp1 power domain can be turned off,
> - no more "imprecise external abort" faults.
> 
> The patchset is based on '[PATCH v5 0/9] Enable HDMI support on Exynos platforms' [1].
> 

It also depends on '[PATCH 0/2] Add HDMI support for Exynos5420 platform' [2].

> It was successfully tested on OdroidXU3.
> 
> [1]: http://permalink.gmane.org/gmane.linux.kernel.samsung-soc/42743

Your patches looks good to me so please feel free to add:

Reviewed-by: Javier Martinez Canillas <javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>

I also tested on an Exynos5420 Peach Pit Chromebook and both the "Power
domain power-domain disable failed" message and the system crash are gone.

Tested-by: Javier Martinez Canillas <javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>

Best regards,
Javier

[2]: https://lkml.org/lkml/2015/1/20/235
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-02-05 14:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-05 12:35 [RFC PATCH 0/3] Fix power domains handling on exynos542x Andrzej Hajda
2015-02-05 12:35 ` [RFC PATCH 1/3] arm/exynos: add asynchronous bridge clock bindings Andrzej Hajda
2015-02-05 12:35 ` [RFC PATCH 2/3] arm/exynos/pm_domains: add support for async-bridge clocks Andrzej Hajda
2015-03-12 13:05   ` Sylwester Nawrocki
2015-02-05 12:35 ` [RFC PATCH 3/3] ARM: dts: exynos5420: add async-bridge clock to disp1 power domain Andrzej Hajda
     [not found] ` <1423139739-19881-1-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-02-05 14:45   ` Javier Martinez Canillas [this message]
2015-02-06  5:27     ` [RFC PATCH 0/3] Fix power domains handling on exynos542x Joonyoung Shim
2015-02-06  9:18       ` Javier Martinez Canillas
2015-02-06 10:55         ` [RFC PATCH v2 3/3] ARM: dts: exynos5420: add async-bridge clocks to disp1 power domain Andrzej Hajda
     [not found]           ` <1423220154-5333-1-git-send-email-a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-02-06 11:27             ` Javier Martinez Canillas
2015-03-03  8:12               ` Javier Martinez Canillas
2015-03-12 13:00           ` Sylwester Nawrocki
2015-03-10  9:48     ` [RFC PATCH 0/3] Fix power domains handling on exynos542x Javier Martinez Canillas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54D381F4.2080701@collabora.co.uk \
    --to=javier.martinez-zgy8ohtn/8ppycu2f3hruq@public.gmane.org \
    --cc=Liquid.Acid-hi6Y0CQ0nG0@public.gmane.org \
    --cc=a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox