Linux Samsung SOC development
 help / color / mirror / Atom feed
From: Inki Dae <inki.dae@samsung.com>
To: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
Cc: linux-samsung-soc@vger.kernel.org, emil.l.velikov@gmail.com,
	dri-devel@lists.freedesktop.org, robclark@freedesktop.org,
	m.szyprowski@samsung.com
Subject: Re: [PATCH v3 14/17] exynos: fimg2d: fix comment for G2D_COEFF_MODE_GB_COLOR
Date: Wed, 11 Mar 2015 22:11:03 +0900	[thread overview]
Message-ID: <55003EE7.3060904@samsung.com> (raw)
In-Reply-To: <1424787655-10739-15-git-send-email-tjakobi@math.uni-bielefeld.de>

Hi Tobias,

On 2015년 02월 24일 23:20, Tobias Jakobi wrote:
> The coefficient mode enables use of global color, not alpha.
> 
> Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
> ---
>  exynos/exynos_fimg2d.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/exynos/exynos_fimg2d.h b/exynos/exynos_fimg2d.h
> index dbcb764..418757f 100644
> --- a/exynos/exynos_fimg2d.h
> +++ b/exynos/exynos_fimg2d.h
> @@ -159,7 +159,7 @@ enum e_g2d_coeff_mode {
>  	G2D_COEFF_MODE_DST_COLOR,
>  	/* Global Alpha : Set by ALPHA_REG(0x618) */
>  	G2D_COEFF_MODE_GB_ALPHA,
> -	/* Global Alpha : Set by ALPHA_REG(0x618) */
> +	/* Global Color : Set by ALPHA_REG(0x618) */

Actually, above register sets not only global color value but also
global alpha value. Below shows fields of the register,

ColorValue  [31:8]   Global color value (RGB order)
AlphaValue [7:0]  Global alpha value

So right comment would be "Global Color and Global Alpha".

Thanks,
Inki Dae

>  	G2D_COEFF_MODE_GB_COLOR,
>  	/* (1-SRC alpha)/DST Alpha */
>  	G2D_COEFF_MODE_DISJOINT_S,
> 

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2015-03-11 13:11 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-24 14:20 [v3] libdrm: improvements to userspace exynos component Tobias Jakobi
2015-02-24 14:20 ` [PATCH v3 01/17] tests/exynos: fimg2d: add a checkerboard test Tobias Jakobi
2015-02-24 14:20 ` [PATCH v3 02/17] exynos: replace G2D_DOUBLE_TO_FIXED macro with function Tobias Jakobi
2015-02-24 14:20 ` [PATCH v3 03/17] tests/exynos: fix typos and change wording Tobias Jakobi
2015-02-24 14:20 ` [PATCH v3 04/17] tests/exynos: disable the G2D userptr/blend test Tobias Jakobi
2015-02-24 14:20 ` [PATCH v3 05/17] exynos: add g2d_scale_and_blend Tobias Jakobi
2015-02-24 14:20 ` [PATCH v3 06/17] tests/exynos: introduce wait_for_user_input Tobias Jakobi
2015-02-24 14:20 ` [PATCH v3 07/17] exynos: honor the repeat mode in g2d_copy_with_scale Tobias Jakobi
2015-02-24 14:20 ` [PATCH v3 08/17] exynos: introduce g2d_add_base_addr helper function Tobias Jakobi
2015-02-24 14:20 ` [PATCH v3 09/17] exynos: use structure initialization instead of memset Tobias Jakobi
2015-02-24 14:20 ` [PATCH v3 10/17] tests/exynos: improve error handling Tobias Jakobi
2015-02-24 14:20 ` [PATCH v3 11/17] exynos: add exynos prefix to fimg2d header Tobias Jakobi
2015-02-24 14:20 ` [PATCH v3 12/17] exynos: fimg2d: remove TRUE/FALSE from header Tobias Jakobi
2015-02-24 14:20 ` [PATCH v3 13/17] exynos: add fimg2d header to common includes Tobias Jakobi
2015-02-24 14:20 ` [PATCH v3 14/17] exynos: fimg2d: fix comment for G2D_COEFF_MODE_GB_COLOR Tobias Jakobi
2015-03-11 13:11   ` Inki Dae [this message]
2015-02-25 15:54 ` [v3] libdrm: improvements to userspace exynos component Emil Velikov
2015-03-08 14:30   ` Emil Velikov
2015-03-08 23:12     ` Tobias Jakobi
2015-03-10 19:36       ` Emil Velikov
2015-03-11  1:09         ` Inki Dae
2015-03-11 13:31 ` Inki Dae
2015-03-11 18:56   ` Emil Velikov
2015-03-11 19:40     ` Tobias Jakobi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55003EE7.3060904@samsung.com \
    --to=inki.dae@samsung.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emil.l.velikov@gmail.com \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=robclark@freedesktop.org \
    --cc=tjakobi@math.uni-bielefeld.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox