From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
To: Chanwoo Choi <cw00.choi@samsung.com>,
Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
Cc: linux-samsung-soc@vger.kernel.org, m.reichl@fivetechno.de
Subject: Re: [PATCH] ARM: dts: exynos4412-odroid: add 'rtc_src' clock to rtc node
Date: Fri, 20 Mar 2015 09:56:33 +0100 [thread overview]
Message-ID: <550BE0C1.4020500@collabora.co.uk> (raw)
In-Reply-To: <550B7A2C.4070403@samsung.com>
Hello,
On 03/20/2015 02:38 AM, Chanwoo Choi wrote:
> On 03/20/2015 10:29 AM, Tobias Jakobi wrote:
>> From: Markus Reichl <m.reichl@fivetechno.de>
>>
>> The Exynos4412 SoC has a s3c6410 RTC where the source clock
>> is now a mandatory property.
>>
>> This patch fixes probe failure of s3c-rtc on Odroid-X2/U2/U3 boards.
>>
>> Signed-off-by: Markus Reichl <m.reichl@fivetechno.de>
>> Tested-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
>> ---
>> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>> index 1ff4c88..0a8e6aa4 100644
>> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>> @@ -9,6 +9,7 @@
>>
>> #include <dt-bindings/sound/samsung-i2s.h>
>> #include <dt-bindings/input/input.h>
>> +#include <dt-bindings/clock/maxim,max77686.h>
>> #include "exynos4412.dtsi"
>>
>> / {
>> @@ -143,6 +144,8 @@
>>
>> rtc@10070000 {
>> status = "okay";
>> + clocks = <&clock CLK_RTC>, <&max77686 MAX77686_CLK_AP>;
>> + clock-names = "rtc", "rtc_src";
>> };
>>
>> g2d@10800000 {
>>
>
> Exynos's RTC need the XrtcXTI source clock (32.768kHz). Looks good to me.
>
> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
>
Yes, I also think this is the correct fix for these boards.
Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> Thanks,
> Chanwoo Choi
>
Best regards,
Javier
next prev parent reply other threads:[~2015-03-20 8:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 1:29 [PATCH] ARM: dts: exynos4412-odroid: add 'rtc_src' clock to rtc node Tobias Jakobi
2015-03-20 1:38 ` Chanwoo Choi
2015-03-20 8:56 ` Javier Martinez Canillas [this message]
2015-04-03 8:25 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550BE0C1.4020500@collabora.co.uk \
--to=javier.martinez@collabora.co.uk \
--cc=cw00.choi@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.reichl@fivetechno.de \
--cc=tjakobi@math.uni-bielefeld.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox