From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, Kukjin Kim <kgene@kernel.org>,
Tobias Jakobi <tjakobi@math.uni-bielefeld.de>,
Daniel Drake <drake@endlessm.com>
Subject: Re: [PATCH] exynos: pmu: use PS_HOLD based poweroff for all supported SoCs
Date: Fri, 20 Mar 2015 16:11:04 +0100 [thread overview]
Message-ID: <550C3888.7050905@samsung.com> (raw)
In-Reply-To: <CAJKOXPe4=DHsV3_axDUhpimRaqSHA3=HLiSJ1K3DYZoGRRiTTg@mail.gmail.com>
Hello,
On 2015-02-09 11:58, Krzysztof Kozlowski wrote:
> 2015-02-09 10:06 GMT+01:00 Krzysztof Kozlowski <k.kozlowski@samsung.com>:
>> 2015-02-09 8:25 GMT+01:00 Marek Szyprowski <m.szyprowski@samsung.com>:
>>> PS_HOLD based power off procedure is common for all Exynos SoCs, so use
>>> it for every Exynos SoC.
>>>
>>> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
>>> ---
>>> arch/arm/mach-exynos/pmu.c | 6 +++---
>>> 1 file changed, 3 insertions(+), 3 deletions(-)
>> I tried this on Trats2 board (Exynos 4412) and message "Power down
>> failed, please power off system manually." appears. Is it expected? Or
>> am I missing some patches (I applied this on top of next-20150129)?
> It was my fault (I left attached JIG cable which prevents power off).
> Now it works fine.
>
> Tested on Trats2 (Exynos4412):
> Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> Patch also looks good, so:
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Gentle ping for merging this in v4.1-next...
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
next prev parent reply other threads:[~2015-03-20 15:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-09 7:25 [PATCH] exynos: pmu: use PS_HOLD based poweroff for all supported SoCs Marek Szyprowski
2015-02-09 9:06 ` Krzysztof Kozlowski
2015-02-09 10:58 ` Krzysztof Kozlowski
2015-03-20 15:11 ` Marek Szyprowski [this message]
2015-03-20 16:03 ` Tobias Jakobi
2015-03-24 8:06 ` Kukjin Kim
2015-05-20 6:31 ` Krzysztof Kozlowski
2015-02-09 20:24 ` Tobias Jakobi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550C3888.7050905@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=drake@endlessm.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=tjakobi@math.uni-bielefeld.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox