Linux Samsung SOC development
 help / color / mirror / Atom feed
From: Joonyoung Shim <jy0922.shim@samsung.com>
To: Gustavo Padovan <gustavo@padovan.org>,
	linux-samsung-soc@vger.kernel.org,
	dri-devel@lists.freedesktop.org, inki.dae@samsung.com,
	Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Subject: Re: [PATCH 10/10] drm/exynos: atomic dpms support
Date: Fri, 03 Apr 2015 15:46:48 +0900	[thread overview]
Message-ID: <551E3758.8030109@samsung.com> (raw)
In-Reply-To: <20150402140837.GA6970@joana>

Hi,
 
>>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
>>> index e71e331..e0b085b 100644
>>> --- a/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
>>> +++ b/drivers/gpu/drm/exynos/exynos_drm_fbdev.c
>>> @@ -275,9 +275,6 @@ int exynos_drm_fbdev_init(struct drm_device *dev)
>>>  
>>>  	}
>>>  
>>> -	/* disable all the possible outputs/crtcs before entering KMS mode */
>>> -	drm_helper_disable_unused_functions(dev);
>>> -
>>
>> I think this is not related with atomic dpms support, if this needs,
>> could you make another patch?
> 
> Yes, it is, once you port exynos to use atomic dpms we start getting warning
> from this functions, the correct solution is to remove it. Other subsystems
> followed the same approach.

As i said, the warning comes from changes of this patch.

From rcar-du driver, it was handled to a separate patch.

http://www.spinics.net/lists/linux-sh/msg40384.html

> 
> I'm sending an updated patch set in a bit.

OK, but i didn't get your updated patch 10/10 yet. Could you resend it?

Thanks.

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2015-04-03  6:46 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-27 15:58 [PATCH 00/10] drm/exynos: Add atomic modesetting support Gustavo Padovan
2015-03-27 15:58 ` [PATCH 01/10] drm/exynos: atomic phase 1: use drm_plane_helper_update() Gustavo Padovan
2015-03-27 15:58 ` [PATCH 02/10] drm/exynos: atomic phase 1: use drm_plane_helper_disable() Gustavo Padovan
2015-03-27 15:58 ` [PATCH 03/10] drm/exynos: atomic phase 1: add .mode_set_nofb() callback Gustavo Padovan
2015-03-27 15:58 ` [PATCH 04/10] drm/exynos: atomic phase 2: wire up state reset(), duplicate() and destroy() Gustavo Padovan
2015-03-27 15:58 ` [PATCH 05/10] drm/exynos: atomic phase 2: keep track of framebuffer pointer Gustavo Padovan
2015-03-27 15:58 ` [PATCH 06/10] drm/exynos: atomic phase 3: atomic updates of planes Gustavo Padovan
2015-03-27 15:58 ` [PATCH 07/10] drm/exynos: atomic phase 3: use atomic .set_config helper Gustavo Padovan
2015-03-27 15:58 ` [PATCH 08/10] drm/exynos: atomic phase 3: convert page flips Gustavo Padovan
2015-03-27 15:58 ` [PATCH 09/10] drm/exynos: remove exported functions from exynos_drm_plane Gustavo Padovan
2015-03-30 19:11   ` [PATCH 10/10] drm/exynos: atomic dpms support Gustavo Padovan
2015-04-02  9:02     ` Joonyoung Shim
2015-04-02 14:08       ` Gustavo Padovan
2015-04-03  6:46         ` Joonyoung Shim [this message]
2015-04-03 15:06           ` Gustavo Padovan
2015-04-02  8:43   ` [PATCH 09/10] drm/exynos: remove exported functions from exynos_drm_plane Joonyoung Shim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=551E3758.8030109@samsung.com \
    --to=jy0922.shim@samsung.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gustavo.padovan@collabora.co.uk \
    --cc=gustavo@padovan.org \
    --cc=inki.dae@samsung.com \
    --cc=linux-samsung-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox