Linux Samsung SOC development
 help / color / mirror / Atom feed
From: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: linux-samsung-soc@vger.kernel.org,
	ML dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 3/3] drm/exynos: mixer: add 2x scaling to mixer_graph_buffer
Date: Mon, 06 Apr 2015 19:39:00 +0200	[thread overview]
Message-ID: <5522C4B4.6050309@math.uni-bielefeld.de> (raw)
In-Reply-To: <CACvgo50N_LGyA9rx-9y3dUQzu3cx0HhEaZjij=AWVsCf5-ZA2Q@mail.gmail.com>

Hello Emil,

Emil Velikov wrote:
> Hi Tobias,
> 
> On 1 April 2015 at 14:29, Tobias Jakobi <tjakobi@math.uni-bielefeld.de> wrote:
>> diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c
>> index 5ab0e32..6822b36 100644
>> --- a/drivers/gpu/drm/exynos/exynos_mixer.c
>> +++ b/drivers/gpu/drm/exynos/exynos_mixer.c
> 
>> @@ -528,9 +552,8 @@ static void mixer_graph_buffer(struct mixer_context *ctx, int win)
>>                 fmt = ARGB8888;
>>         }
>>
>> -       /* 2x scaling feature */
>> -       x_ratio = 0;
>> -       y_ratio = 0;
>> +       /* check if mixer supports requested scaling setup */
>> +       if (mixer_setup_scale(plane, &x_ratio, &y_ratio)) return;
>>
> Having return on the same line as the if statement will make
> checkpatch.pl unhappy :-(
right, I'm going to fix this and resend the series.

With best wishes,
Tobias

  reply	other threads:[~2015-04-06 17:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-01 13:29 [PATCH 1/3] drm/exynos: fix typos in hdmi and mixer Tobias Jakobi
2015-04-01 13:29 ` [PATCH 2/3] drm/exynos: remove superfluous error messages Tobias Jakobi
2015-04-01 15:33   ` Gustavo Padovan
2015-04-01 13:29 ` [PATCH 3/3] drm/exynos: mixer: add 2x scaling to mixer_graph_buffer Tobias Jakobi
2015-04-01 15:34   ` Gustavo Padovan
2015-04-05 16:40   ` Emil Velikov
2015-04-06 17:39     ` Tobias Jakobi [this message]
2015-04-01 15:33 ` [PATCH 1/3] drm/exynos: fix typos in hdmi and mixer Gustavo Padovan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5522C4B4.6050309@math.uni-bielefeld.de \
    --to=tjakobi@math.uni-bielefeld.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emil.l.velikov@gmail.com \
    --cc=linux-samsung-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox