From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Subject: Re: [PATCH 1/1] ARM: dts: Make DP a consumer of DISP1 power domain on Exynos5420 Date: Thu, 16 Apr 2015 09:40:00 +0200 Message-ID: <552F6750.6020306@collabora.co.uk> References: <1428870659-5525-1-git-send-email-javier.martinez@collabora.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1428870659-5525-1-git-send-email-javier.martinez@collabora.co.uk> Sender: linux-kernel-owner@vger.kernel.org To: Kukjin Kim Cc: Doug Anderson , Olof Johansson , Krzysztof Kozlowski , Andrzej Hajda , Kevin Hilman , Tyler Baker , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org Hello Kukjin, On 04/12/2015 10:30 PM, Javier Martinez Canillas wrote: > Commit ea08de16eb1b ("ARM: dts: Add DISP1 power domain for exynos5420") > added a device node for the Exynos5420 DISP1 power domain but dit not > make the DP controller a consumer of that power domain. > > This causes an "Unhandled fault: imprecise external abort" error if the > exynos-dp driver tries to access the DP controller registers and the PD > was turned off. This lead to a kernel panic and a complete system hang. > > Make the DP controller device node a consumer of the DISP1 power domain > to ensure that the PD is turned on when the exynos-dp driver is probed. > > Fixes: ea08de16eb1b ("ARM: dts: Add DISP1 power domain for exynos5420") > Signed-off-by: Javier Martinez Canillas Any comments about this patch? It's very trivial but fixes a very important regression on Exynos5420 boards with display panel and Peach Pit and Pi have been broken since next-20150401. This [0] is the Peach Pit boot log with yesteday's linux-next for example. Best regards, Javier [0]: http://arm-soc.lixom.net/bootlogs/next/next-20150415/pit-arm-exynos_defconfig.html