Re: [PATCH v2 2/2] drm/exynos: remove unused 'activated' field from exynos_drm_plane

[Joonyoung Shim <jy0922.shim@samsung.com>]

Hi Tobias,

On 04/17/2015 05:04 PM, Tobias Jakobi wrote:
> Hello Joonyoung,
> 
> On 2015-04-17 08:30, Joonyoung Shim wrote:
>> Hi Tobias,
>>
>> On 04/16/2015 04:54 AM, Tobias Jakobi wrote:
>>> No component of Exynos DRM uses this field. Perhaps it was
>>> once meant to provide more fine-grained information in
>>> addition to the status stored in the 'enabled' field.
>>>
>>> Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
>>> Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
>>> ---
>>>  drivers/gpu/drm/exynos/exynos_drm_drv.h | 2 --
>>>  1 file changed, 2 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.h b/drivers/gpu/drm/exynos/exynos_drm_drv.h
>>> index 6a849cf..4c14a89 100644
>>> --- a/drivers/gpu/drm/exynos/exynos_drm_drv.h
>>> +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.h
>>> @@ -77,7 +77,6 @@ extern void exynos4412_qos(u8 tm, u8 ac);
>>>   * @color_key: color key on or off.
>>>   * @local_path: in case of lcd type, local path mode on or off.
>>>   * @transparency: transparency on or off.
>>> - * @activated: activated or not.
>>>   * @enabled: enabled or not.
>>>   * @resume: to resume or not.
>>>   *
>>> @@ -112,7 +111,6 @@ struct exynos_drm_plane {
>>>      bool color_key:1;
>>>      bool local_path:1;
>>>      bool transparency:1;
>>> -    bool activated:1;
>>>      bool enabled:1;
>>>      bool resume:1;
>>>  };
>>>
>>
>> The following fields also are unused in exynos drm driver,
>> - default win, color_key, local_path, transparency
> Yeah, looks like it. I just stumbled upon 'activated' because I was wondering what the difference between 'enabled' and 'activated' was. Grepping than revealed that nothing was using that field. I didn't check any other fields.
> 

Actually i don't know about activated field but i think maybe activated
field and other fields seem be just reserved for any features later when
exynos drm driver was posted first.

> Also I just noticed that due to how git formats the patches, this one doesn't apply to any of Inki's branches (due to the 'extern void exynos4412_qos(u8 tm, u8 ac);' line).
> 
> Should I respin this, and if yes, should I also drop the other fields mentioned? Question is more directed to Gustavo, since he's cleaning 'exynos_drm_plane' anyway.
> 

I think you can post patch based on latest branch(exynos-drm-next) of
Inki with removing other fields.

Thanks.

> 
>> Inki, how about remove unused fields?
>>
>> Thanks.
> 
> 
> With best wishes,
> Tobias
> 
> 
> 

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel