From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Subject: Re: [RESEND PATCH 4/8] mfd: cros_ec: Use a zero-length array for command data Date: Tue, 05 May 2015 17:53:01 +0200 Message-ID: <5548E75D.5050407@collabora.co.uk> References: <1428336906-14906-1-git-send-email-javier.martinez@collabora.co.uk> <1428336906-14906-5-git-send-email-javier.martinez@collabora.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Gwendal Grignou Cc: Olof Johansson , Lee Jones , Doug Anderson , Bill Richardson , Simon Glass , Stephen Barber , Filipe Brandenburger , Todd Broch , linux-samsung-soc@vger.kernel.org, Linux Kernel List-Id: linux-samsung-soc@vger.kernel.org Hello Gwendal, Thanks a lot for your feedback. On 04/24/2015 07:19 AM, Gwendal Grignou wrote: > In general we can use kmalloc instead of kzalloc. Also some commands > do not need malloc at all. We could allocate on stack for known small > commands and for the keyboard case use the caller argument. > Sure, I'll do all the changes that you suggested when respinning the patches. > Gwendal. > Best regards, Javier