Re: [PATCHv5 5/5] ARM: dts: Enable thermal_zone for exynos5422-odroidxu3

Krzysztof Kozlowski
2015-05-13T10:05:41Z

2015-05-13 17:39 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
> On 13 May 2015 at 13:10, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
>> 2015-05-13 15:37 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>>> Include exynos5-cpu-thermal.dtsi to enable thermal_zone support.
>>
>> I am a little confused because you named this file as
>> exynos5-cpu-thermal, meaning it is common for all Exynos5 boards. But:
>> 1. It references some specific phandles like &fan0 (cooling-device =
>> <&fan0 2 3>).
>> 2. You include it only here.
>>
>> So the question: is "exynos5-cpu-thermal.dtsi" a generic thermal DTSI?
>> What is your intention?
>>
>> Lukasz, you acked the patchset, is it fine?
>>
>> Best regards,
>> Krzysztof
>
> Hi Krysxtof,
>
> This file almost similar to below patch
>
> https://patchwork.kernel.org/patch/5693321/

It is similar but it has major difference: it references external (to
the file) phandle: fan0.

> I had to create this new file as I was not able to register
> #thermal-sensors to tmu_cpu0.
>
> + thermal-zones {
> + cpu0_thermal: cpu0-thermal {
> + thermal-sensors = <&tmu_cpu0 0>;
> + polling-delay-passive = <0>;
> + polling-delay = <0>;
>
> Earlier the DTS sensor's were not getting registers to the tmu_cpu0 sensors.
>
> I am not aware If this file will be common to Exynos5 series.
> I could not include any common dts file as I would through me
> compilation error hence .dtsi extension,

So this looks exynos5420-odroidxu3 specific.

Łukasz, does this design looks good to you? You acked this but:
1. I cannot find your ack for patch 3/5.
2. I have doubts. :)

Best regards,
Krzysztof