From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [RFC PATCH 2/4] ARM: dts: Add SPI flash node for Peach boards Date: Thu, 21 May 2015 09:44:07 +0900 Message-ID: <555D2A57.5090702@samsung.com> References: <1432042454-19234-1-git-send-email-javier.martinez@collabora.co.uk> <1432042454-19234-3-git-send-email-javier.martinez@collabora.co.uk> <555C0179.8040102@samsung.com> <555C5F55.9010507@collabora.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout4.w1.samsung.com ([210.118.77.14]:50139 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753452AbbEUAoN (ORCPT ); Wed, 20 May 2015 20:44:13 -0400 In-reply-to: <555C5F55.9010507@collabora.co.uk> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Javier Martinez Canillas , Mark Brown Cc: Kukjin Kim , Olof Johansson , Doug Anderson , David Hendricks , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Simon Glass On 20.05.2015 19:17, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 05/20/2015 05:37 AM, Krzysztof Kozlowski wrote: >> On 19.05.2015 22:34, Javier Martinez Canillas wrote: >>> From: Simon Glass >>> >>> Peach Pit and Pi machines have a SPI flash memory that is used to >>> store firmware and different system parameters and data. >>> >>> Add information about the SPI flash chip so that user-space tools >>> can access it. >>> >>> Signed-off-by: Simon Glass >>> Reviewed-by: Doug Anderson >>> Signed-off-by: Javier Martinez Canillas >> >> Acked-by: Krzysztof Kozlowski >> >> I assume this can go through samsung-soc tree (after documenting new >> compatible)? >> > > Yes, I mentioned in the cover letter that patch #1 should go through > the spi tree and #2-4 through the linux-samsung tree. I can split in > two series once I post as proper patches to make it more clear. It is fine, don't split it. It is good to see the usage of binding in the same patchset. > >> The exynos5800-peach-pi.dts and exynos5420-peach-pit.dts have a lot of >> common nodes. I wonder if there is a common part which could have its >> own dtsi? Like exynos4412-odroid-common.dtsi? >> > > We discussed in the past about having a common .dtsi [0]. I'm not a > huge fan of a common .dtsi and I prefer to instead split common dts > fragments in a .dtsi that can be included in different dts. > > That also better reflects what happens at the hw level IMHO since a > board may reuse a IP block. Doug Anderson seems to agree with me [1]. Seems reasonable. Best regards, Krzysztof