From mboxrd@z Thu Jan 1 00:00:00 1970 From: Inki Dae Subject: Re: [PATCH v7 12/13] drm/exynos: atomic dpms support Date: Wed, 27 May 2015 21:27:03 +0900 Message-ID: <5565B817.6080001@samsung.com> References: <1432309253-18572-1-git-send-email-gustavo@padovan.org> <1432309253-18572-13-git-send-email-gustavo@padovan.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mailout4.samsung.com ([203.254.224.34]:62365 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751445AbbE0M1K (ORCPT ); Wed, 27 May 2015 08:27:10 -0400 Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout4.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NP000KOOD98AGB0@mailout4.samsung.com> for linux-samsung-soc@vger.kernel.org; Wed, 27 May 2015 21:27:08 +0900 (KST) In-reply-to: <1432309253-18572-13-git-send-email-gustavo@padovan.org> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Gustavo Padovan Cc: linux-samsung-soc@vger.kernel.org, dri-devel@lists.freedesktop.org, jy0922.shim@samsung.com, tjakobi@math.uni-bielefeld.de, Gustavo Padovan Hi Gustavo, On 2015=EB=85=84 05=EC=9B=94 23=EC=9D=BC 00:40, Gustavo Padovan wrote: > From: Gustavo Padovan >=20 > Run dpms operations through the atomic intefaces. This basically remo= ves > the .dpms() callback from econders and crtcs and use .disable() and > .enable() to turn the crtc on and off. >=20 > v2: Address comments by Joonyoung: > - make hdmi code call ->disable() instead of ->dpms() > - do not use WARN_ON on crtc enable/disable >=20 > v3: - Fix build failure after the hdmi change in v2 > - Change dpms helper of ptn3460 bridge >=20 > Signed-off-by: Gustavo Padovan > Reviewed-by: Joonyoung Shim > Tested-by: Tobias Jakobi > --- > drivers/gpu/drm/bridge/ps8622.c | 2 +- > drivers/gpu/drm/bridge/ptn3460.c | 2 +- > drivers/gpu/drm/exynos/exynos_dp_core.c | 2 +- > drivers/gpu/drm/exynos/exynos_drm_crtc.c | 95 ++++++++++++++++---= ---------- > drivers/gpu/drm/exynos/exynos_drm_dpi.c | 2 +- > drivers/gpu/drm/exynos/exynos_drm_drv.h | 4 +- > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 2 +- > drivers/gpu/drm/exynos/exynos_drm_encoder.c | 27 ++------ > drivers/gpu/drm/exynos/exynos_drm_vidi.c | 2 +- > drivers/gpu/drm/exynos/exynos_hdmi.c | 6 +- > 10 files changed, 69 insertions(+), 75 deletions(-) >=20 > diff --git a/drivers/gpu/drm/bridge/ps8622.c b/drivers/gpu/drm/bridge= /ps8622.c > index b604326..d686235 100644 > --- a/drivers/gpu/drm/bridge/ps8622.c > +++ b/drivers/gpu/drm/bridge/ps8622.c > @@ -499,7 +499,7 @@ static void ps8622_connector_destroy(struct drm_c= onnector *connector) > } > =20 > static const struct drm_connector_funcs ps8622_connector_funcs =3D { > - .dpms =3D drm_helper_connector_dpms, > + .dpms =3D drm_atomic_helper_connector_dpms, > .fill_modes =3D drm_helper_probe_single_connector_modes, > .detect =3D ps8622_detect, > .destroy =3D ps8622_connector_destroy, > diff --git a/drivers/gpu/drm/bridge/ptn3460.c b/drivers/gpu/drm/bridg= e/ptn3460.c > index 8ed3617..260bc9f 100644 > --- a/drivers/gpu/drm/bridge/ptn3460.c > +++ b/drivers/gpu/drm/bridge/ptn3460.c > @@ -260,7 +260,7 @@ static void ptn3460_connector_destroy(struct drm_= connector *connector) > } > =20 > static struct drm_connector_funcs ptn3460_connector_funcs =3D { > - .dpms =3D drm_helper_connector_dpms, > + .dpms =3D drm_atomic_helper_connector_dpms, > .fill_modes =3D drm_helper_probe_single_connector_modes, > .detect =3D ptn3460_detect, > .destroy =3D ptn3460_connector_destroy, > diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c b/drivers/gpu/dr= m/exynos/exynos_dp_core.c > index 195fe60..c9995b1 100644 > --- a/drivers/gpu/drm/exynos/exynos_dp_core.c > +++ b/drivers/gpu/drm/exynos/exynos_dp_core.c > @@ -954,7 +954,7 @@ static void exynos_dp_connector_destroy(struct dr= m_connector *connector) > } > =20 [--snip--] > =20 > static struct drm_crtc_helper_funcs exynos_crtc_helper_funcs =3D { > - .dpms =3D exynos_drm_crtc_dpms, > - .prepare =3D exynos_drm_crtc_prepare, > - .commit =3D exynos_drm_crtc_commit, > + .enable =3D exynos_drm_crtc_enable, > + .disable =3D exynos_drm_crtc_disable, > .mode_fixup =3D exynos_drm_crtc_mode_fixup, > .mode_set =3D drm_helper_crtc_mode_set, > .mode_set_nofb =3D exynos_drm_crtc_mode_set_nofb, I think it'd be better to use atomic_flush callback to enable global dm= a like commit callback did. Is there any reason that you don't use atomic_begin and atomic_flush callbacks? atomic relevant codes I looked into do as follows, atomic_begin(); atomic_update(); /* this will call win_commit callback to set a overla= y relevant registers and enable its dma channel. */ atomic_flush(); So atomic overlay updating between atomic_begin() ~ atomic_flush() will be guaranteed. Thanks, Inki Dae > .mode_set_base =3D drm_helper_crtc_mode_set_base, > - .disable =3D exynos_drm_crtc_disable, > + .atomic_check =3D exynos_crtc_atomic_check, > }; > =20 [--snip--]