Re: [PATCH v3 5/7] mfd: cros_ec: add bus-specific proto v3 code

Javier Martinez Canillas
2015-05-27T09:06:59Z

Hello Lee,

On 05/27/2015 10:53 AM, Lee Jones wrote:
> On Fri, 22 May 2015, Javier Martinez Canillas wrote:
>
>> From: Stephen Barber <smbarber@chromium.org>
>>
>> Add proto v3 support to the SPI, I2C, and LPC.
>>
>> Signed-off-by: Stephen Barber <smbarber@chromium.org>
>> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>> Tested-by: Heiko Stuebner <heiko@sntech.de>
>> Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
>> Tested-by: Gwendal Grignou <gwendal@chromium.org>
>> ---
>>
>> Changes since v2: None
>>
>> Changes since v1:
>> - Added Gwendal Grignou Reviewed-by and Tested-by tags
>> ---
>> drivers/mfd/cros_ec_i2c.c | 166 ++++++++++++++-
>> drivers/mfd/cros_ec_spi.c | 382 +++++++++++++++++++++++++++++-----
>> drivers/platform/chrome/cros_ec_lpc.c | 73 ++++++-
>> include/linux/mfd/cros_ec.h | 6 +
>> 4 files changed, 569 insertions(+), 58 deletions(-)
>
> I don't even know what to say; except, 600 lines of grimness! I tried
> to review, but now my eyes and brain hurt. I feel sorry for the guys
> who have to actively maintain this stuff.
>

Since I'm not the author of these drivers, it took me some time to
understand them as well. I've been trying to make it more suitable
for upstream and were improved a lot by following your suggestions
(thanks for a lot that!).

> However... you have enough vendor Acks and Tests to make me "happy",
> and if anything is wrong I'm sure you'll come back and fix it
> promptyly.
>

Yes I will and I'm sure that being in mainline will make the code
more maintainable in the long term.

> Acked-by: Lee Jones <lee.jones@linaro.org>
>

Thanks and best regards,
Javier