Re: [PATCH v10 17/17] drm/exynos: split exynos_crtc->dpms in enable() and disable()

Inki Dae
2015-06-03T01:08:47Z

On 2015년 06월 02일 23:19, Javier Martinez Canillas wrote:
> Hello Gustavo,
>
> On Tue, Jun 2, 2015 at 4:06 PM, Gustavo Padovan <gustavo@padovan.org> wrote:
>> Hi Inki,
>>
>> 2015-06-02 Inki Dae <inki.dae@samsung.com>:
>>
>>> Hi,
>>>
>>> On 2015년 06월 02일 00:04, Gustavo Padovan wrote:
>>>> From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
>>>>
>>>> To follow more closely the new atomic API we split the dpms()
>>>> helper into the enable() and disable() helper to get exactly the
>>>> same semantics.
>>>
>>> Below is the result from checkpatch.pl. Please fix all errors and check
>>> your patch with checkpatch.pl before posting it.
>>>
>>> Thanks,
>>> Inki Dae
>>>
>>> total: 62 errors, 0 warnings, 410 lines checked
>>
>> I think you did something wrong when checking, for me it looks like
>> this:
>>
>> 0016-drm-exynos-split-exynos_crtc-dpms-in-enable-and-disa.patch has no
>> obvious style problems and is ready for submission.
>> WARNING: Do not use whitespace before Signed-off-by:
>> #12:
>> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
>>
>> total: 0 errors, 1 warnings, 594 lines checked
>>
>
> I also don't get any checkpatch.pl error or warnings when testing your patch:
>
> $ pwclient get 6523251
> Saved patch to v10-17-17-drm-exynos-split-exynos_crtc--dpms-in-enable-and-disable.patch.0
>
> $ ./scripts/checkpatch.pl
> v10-17-17-drm-exynos-split-exynos_crtc--dpms-in-enable-and-disable.patch
> total: 0 errors, 0 warnings, 410 lines checked
>
> v10-17-17-drm-exynos-split-exynos_crtc--dpms-in-enable-and-disable.patch
> has no obvious style problems and is ready for submission.

Yes, there was something wrong. While coping this patch series to my PC,
it seems that the text format of this patch file was mutated.

Thanks for checking,
Inki Dae

>
>> Gustavo
>
> Best regards,
> Javier
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org