From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Chanho Park <parkch98@gmail.com>
Cc: Kukjin Kim <kgene@kernel.org>,
jy0922.shim@samsung.com, cw00.choi@samsung.com,
linux-samsung-soc@vger.kernel.org,
Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
Kevin Hilman <khilman@linaro.org>,
Sjoerd Simons <sjoerd.simons@collabora.co.uk>,
heesub.shin@samsung.com,
Marek Szyprowski <m.szyprowski@samsung.com>,
b.zolnierkie@samsung.com, Chanho Park <chanho61.park@samsung.com>
Subject: Re: [PATCHv3] ARM: dts: add exynos5422-cpus.dtsi to correct cpu order
Date: Thu, 02 Jul 2015 08:50:00 +0900 [thread overview]
Message-ID: <55947CA8.5060407@samsung.com> (raw)
In-Reply-To: <CAPTzV15go4HVp0roO2f-b6ZCjgA1L_yABD7FE6bHiutAu1rM4A@mail.gmail.com>
On 01.07.2015 22:35, Chanho Park wrote:
> Hi,
>
> On Tue, Jun 2, 2015 at 8:55 AM, Krzysztof Kozlowski
> <k.kozlowski@samsung.com> wrote:
>> On 01.06.2015 21:24, Chanho Park wrote:
>>> The odroid-xu3 board which is based on exynos5422 not exynos5800 is
>>> booted from cortex-a7 core unlike exynos5800. The odroid-xu3's cpu order
>>> is quite strange. cpu0 and cpu5-7 are cortex-a7 cores and cpu1-4 are
>>> cortex-a15 cores. To correct this mis-odering, I added exynos5422.dtsi
>>> and reversing cpu orders from exynos5420. Now, cpu0-3 are cortex-a7 and
>>> cpu4-7 are cortex-a15.
>>>
>>> Signed-off-by: Chanho Park <chanho61.park@samsung.com>
>>> ---
>>> Change from v2:
>>> - drop inclusion of exynos5420.dtsi from exynos5422-cpus.dtsi
>>> - drop compatibles from exynos5422-cpus.dtsi
>>>
>>> Changes from v1:
>>> - rename exynos5422.dtsi to exynos5422-cpus.dtsi
>>> - include the dtsi file top of the exynos5422-odroidxu3.dts
>>>
>>> arch/arm/boot/dts/exynos5422-cpus.dtsi | 81 ++++++++++++++++++++++++++++++
>>> arch/arm/boot/dts/exynos5422-odroidxu3.dts | 4 +-
>>> 2 files changed, 84 insertions(+), 1 deletion(-)
>>> create mode 100644 arch/arm/boot/dts/exynos5422-cpus.dtsi
>>
>>
>> Looks good,
>> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>>
>> Best regards,
>> Krzysztof
>>
>
> Could you pick up this patch or should I request it to Kukjin?
I reviewed it already so Kukjin should pick it up with my tag.
Anyway it does not apply, probably because of changes in Odroid XU3 DTS
(a common DTSI was added).
Best regards,
Krzysztof
next prev parent reply other threads:[~2015-07-01 23:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 12:24 [PATCHv3] ARM: dts: add exynos5422-cpus.dtsi to correct cpu order Chanho Park
2015-06-01 23:55 ` Krzysztof Kozlowski
2015-07-01 13:35 ` Chanho Park
2015-07-01 23:50 ` Krzysztof Kozlowski [this message]
2015-06-02 3:29 ` Peter Chubb
2015-06-02 12:02 ` Krzysztof Kozlowski
2015-06-02 12:49 ` Chanho Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55947CA8.5060407@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=chanho61.park@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=heesub.shin@samsung.com \
--cc=javier.martinez@collabora.co.uk \
--cc=jy0922.shim@samsung.com \
--cc=kgene@kernel.org \
--cc=khilman@linaro.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=parkch98@gmail.com \
--cc=sjoerd.simons@collabora.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox