Re: [PATCH 00/23] drm/exynos: atomic improvements + exynos_encoder removal

[Joonyoung Shim <jy0922.shim@samsung.com>]

Hi Gustavo,

On 06/24/2015 06:35 AM, Gustavo Padovan wrote:
> From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> 
> Hi,
> 
> This set improves exynos in a number of ways. The first five patches are
> general clean up/fixes.
> 
> Patches 06 to 12 are improvements on top of the newly added atomic modesetting
> support.

I'm not sure yet whether need locking for atomic asynchronous commit.

> 
> Patches 13-23 are a big journey to completely remove the internal
> exynos_drm_encoder struct. Now exynos encoders register themselves directly
> with the drm core.
> 
> Please review!

I reviewed roughly and i think it seems be almost good. I will test it
if i can have more time.

Thanks.

> 
> 	Gustavo
> 
> Gustavo Padovan (23):
>   drm/exynos: pass the correct pipe number
>   drm/exynos: calculate vrefresh instead of use a fixed value
>   drm/exynos: use KMS version of DRM vblanks functions
>   drm/exynos: remove duplicated check for suspend
>   drm/exynos: Kconfig: select DP if FIMD or DECON are selected
>   drm/exynos: add atomic asynchronous commit
>   drm/exynos: rename win_commit/disable to atomic-like names
>   drm/exynos: pass struct exynos_drm_plane in update/enable
>   drm/exynos: use drm atomic state directly
>   drm/exynos: remove unused fields from struct exynos_drm_plane
>   drm/exynos: unify exynos_drm_plane names with drm core
>   drm/exynos: don't track enabled state at exynos_crtc
>   drm/exynos: split display's .dpms() into .enable() and .disable()
>   drm/exynos: remove wrappers for phy_power_{on,off}
>   drm/exynos: remove unused .remove() and .check_mode() ops from display
>   drm/exynos: simplify calculation of possible CRTCs
>   drm/exynos: remove struct exynos_drm_display
>   drm/exynos: remove extra call to hdmi_commit()
>   drm/exynos: remove extra call to exynos_dp_commit()
>   drm/exynos: remove exynos_encoder's .commit() op
>   drm/exynos: remove exynos_drm_create_enc_conn()
>   drm/exynos: fold encoder setup into exynos_drm_load()
>   drm/exynos: remove struct exynos_drm_encoder layer
> 
>  drivers/gpu/drm/exynos/Kconfig              |   4 +-
>  drivers/gpu/drm/exynos/Makefile             |   7 +-
>  drivers/gpu/drm/exynos/exynos7_drm_decon.c  |  86 +++++++-------
>  drivers/gpu/drm/exynos/exynos_dp_core.c     | 122 +++++++++----------
>  drivers/gpu/drm/exynos/exynos_dp_core.h     |   3 +-
>  drivers/gpu/drm/exynos/exynos_drm_core.c    |  36 ------
>  drivers/gpu/drm/exynos/exynos_drm_crtc.c    |  33 ++----
>  drivers/gpu/drm/exynos/exynos_drm_crtc.h    |   4 +-
>  drivers/gpu/drm/exynos/exynos_drm_dpi.c     |  96 ++++++++-------
>  drivers/gpu/drm/exynos/exynos_drm_drv.c     |  19 ++-
>  drivers/gpu/drm/exynos/exynos_drm_drv.h     | 115 +++++-------------
>  drivers/gpu/drm/exynos/exynos_drm_dsi.c     | 129 ++++++++++-----------
>  drivers/gpu/drm/exynos/exynos_drm_encoder.c | 174 ----------------------------
>  drivers/gpu/drm/exynos/exynos_drm_encoder.h |  23 ----
>  drivers/gpu/drm/exynos/exynos_drm_fb.c      |  51 ++++++--
>  drivers/gpu/drm/exynos/exynos_drm_fimd.c    |  99 +++++++---------
>  drivers/gpu/drm/exynos/exynos_drm_plane.c   |  31 ++---
>  drivers/gpu/drm/exynos/exynos_drm_vidi.c    | 107 +++++++++--------
>  drivers/gpu/drm/exynos/exynos_hdmi.c        | 168 +++++++++++++--------------
>  drivers/gpu/drm/exynos/exynos_mixer.c       | 111 +++++++++---------
>  20 files changed, 572 insertions(+), 846 deletions(-)
>  delete mode 100644 drivers/gpu/drm/exynos/exynos_drm_encoder.c
>  delete mode 100644 drivers/gpu/drm/exynos/exynos_drm_encoder.h
> 

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel